ceilometer role pulls panko-api image

[Pierre Riteau]

On branches still including panko (wallaby and older), the panko default variables are used when calling the ceilometer role:

- name: Apply role ceilometer
  gather_facts: false
  vars_files:
    - "roles/panko/defaults/main.yml"
  hosts:
    - ceilometer-central
    - ceilometer-notification
    - ceilometer-compute
    - ceilometer-ipmi
    - '&enable_ceilometer_True'
  serial: '{{ kolla_serial|default("0") }}'
  roles:
    - { role: ceilometer,
        tags: ceilometer,
        when: enable_ceilometer | bool }

Play vars_files take precedence over role defaults, which means project_name is redefined as panko.

This causes an issue with image pulling: the ceilometer role tries to pull the panko image. This issue was introduced by the recent refactoring of image pulling into a dedicated service-images-pull role, which uses the project_name variable.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/818714

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/818714
Committed: https://opendev.org/openstack/kolla-ansible/commit/56fc74f23150a9be0c88518ec98bc6a2848ff168
Submitter: "Zuul (22348)"
Branch: master

commit 56fc74f23150a9be0c88518ec98bc6a2848ff168
Author: Pierre Riteau <email address hidden>
Date: Mon Nov 22 08:26:57 2021 +0100

    Move project_name and kolla_role_name to role vars

    Role vars have a higher precedence than role defaults. This allows to
    import default vars from another role via vars_files without overriding
    project_name (see related bug for details).

    Change-Id: I3d919736e53d6f3e1a70d1267cf42c8d2c0ad221
    Related-Bug: #1951785

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/823706

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/823708

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/823709

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/823712

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/823706
Committed: https://opendev.org/openstack/kolla-ansible/commit/6c695564bcb29792460ae54aaac2b3b2a6096578
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 6c695564bcb29792460ae54aaac2b3b2a6096578
Author: Pierre Riteau <email address hidden>
Date: Mon Nov 22 08:26:57 2021 +0100

    Move project_name and kolla_role_name to role vars

    Role vars have a higher precedence than role defaults. This allows to
    import default vars from another role via vars_files without overriding
    project_name (see related bug for details).

    Compared to master, this cherry picked change includes the vmtp role.

    Change-Id: I3d919736e53d6f3e1a70d1267cf42c8d2c0ad221
    Related-Bug: #1951785
    (cherry picked from commit 56fc74f23150a9be0c88518ec98bc6a2848ff168)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/823708
Committed: https://opendev.org/openstack/kolla-ansible/commit/6cb0e1062605b4f0f9aeb9884d25a36c91b4bed7
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 6cb0e1062605b4f0f9aeb9884d25a36c91b4bed7
Author: Pierre Riteau <email address hidden>
Date: Mon Nov 22 08:26:57 2021 +0100

    Move project_name and kolla_role_name to role vars

    Role vars have a higher precedence than role defaults. This allows to
    import default vars from another role via vars_files without overriding
    project_name (see closed bug for details).

    Compared to xena, this cherry picked change includes the chrony,
    haproxy, panko, rally and tempest roles.

    Change-Id: I3d919736e53d6f3e1a70d1267cf42c8d2c0ad221
    Closes-Bug: #1951785
    (cherry picked from commit 56fc74f23150a9be0c88518ec98bc6a2848ff168)
    (cherry picked from commit 6c695564bcb29792460ae54aaac2b3b2a6096578)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/823709
Committed: https://opendev.org/openstack/kolla-ansible/commit/145e64d5ca00374ad9ef86a103624db9a5e6642e
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 145e64d5ca00374ad9ef86a103624db9a5e6642e
Author: Pierre Riteau <email address hidden>
Date: Mon Nov 22 08:26:57 2021 +0100

    Move project_name and kolla_role_name to role vars

    Role vars have a higher precedence than role defaults. This allows to
    import default vars from another role via vars_files without overriding
    project_name (see closed bug for details).

    Compared to wallaby, this cherry picked change includes the karbor,
    qinling and searchlight roles.

    Change-Id: I3d919736e53d6f3e1a70d1267cf42c8d2c0ad221
    Closes-Bug: #1951785
    (cherry picked from commit 56fc74f23150a9be0c88518ec98bc6a2848ff168)
    (cherry picked from commit 6c695564bcb29792460ae54aaac2b3b2a6096578)
    (cherry picked from commit 6cb0e1062605b4f0f9aeb9884d25a36c91b4bed7)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/823712
Committed: https://opendev.org/openstack/kolla-ansible/commit/229c3ad585752f9157791d541ad380196d786765
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 229c3ad585752f9157791d541ad380196d786765
Author: Pierre Riteau <email address hidden>
Date: Mon Nov 22 08:26:57 2021 +0100

    Move project_name and kolla_role_name to role vars

    Role vars have a higher precedence than role defaults. This allows to
    import default vars from another role via vars_files without overriding
    project_name (see closed bug for details).

    Compared to victoria, this cherry picked change includes the congress,
    mongodb and nova-hyperv roles.

    Change-Id: I3d919736e53d6f3e1a70d1267cf42c8d2c0ad221
    Closes-Bug: #1951785
    (cherry picked from commit 56fc74f23150a9be0c88518ec98bc6a2848ff168)
    (cherry picked from commit 6c695564bcb29792460ae54aaac2b3b2a6096578)
    (cherry picked from commit 6cb0e1062605b4f0f9aeb9884d25a36c91b4bed7)
    (cherry picked from commit 145e64d5ca00374ad9ef86a103624db9a5e6642e)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla-ansible 11.3.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla-ansible 12.4.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla-ansible ussuri-eol release.