Copying Grafana home dashboard file fails with permission denied

Bug #1947710 reported by Uwe Grawert
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla-ansible
Fix Released
Medium
Unassigned
Victoria
Fix Released
Undecided
Unassigned
Wallaby
Fix Released
Undecided
Unassigned
Xena
Fix Released
Undecided
Unassigned

Bug Description

**Bug Report**

What happened:
Deploying a custom home dashboard file fails, because the copy job is not using privilege escalation.

What you expected to happen:
The custom dashboard file should be copied to the destination host.

How to reproduce it (minimal and precise):
* Set a custom dashboard file to {{ node_config_directory }}/grafana/grafana_home_dashboard.json
* Run kolla-ansible

```
TASK [grafana : Copying over grafana home dashboard if exists] *********************************************************************************************************************************************************************
2021-10-11 13:56:00,229 INFO ansible: TASK [grafana : Copying over grafana home dashboard if exists] *********************************************************************************************************************************************************************
fatal: [control1]: FAILED! => {"msg": "Failed to get information on remote file (/etc/kolla/grafana/grafana_home_dashboard.json): Permission denied"}
2021-10-11 13:56:00,961 ERROR ansible: fatal: [control1]: FAILED! => {"msg": "Failed to get information on remote file (/etc/kolla/grafana/grafana_home_dashboard.json): Permission denied"}
```

A PR has been created: https://review.opendev.org/c/openstack/kolla-ansible/+/813185

Mark Goddard (mgoddard)
Changed in kolla-ansible:
importance: Undecided → Medium
status: New → Triaged
Changed in kolla-ansible:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (master)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/813185
Committed: https://opendev.org/openstack/kolla-ansible/commit/82b0e095a56a9707268f83484292589902ab1c8a
Submitter: "Zuul (22348)"
Branch: master

commit 82b0e095a56a9707268f83484292589902ab1c8a
Author: Uwe Grawert <email address hidden>
Date: Fri Oct 8 12:15:36 2021 +0200

    Grafana: Run priviliged when copying home dashboard file

    The copy job for the grafana home dashboard file needs to run
    priviliged, otherwise permission denied error occurs.

    Closes-Bug: #1947710

    Change-Id: Ib15e961e5193af55e45a443305a96667295f3cb7

Changed in kolla-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 14.0.0.0rc1

This issue was fixed in the openstack/kolla-ansible 14.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/yoga)

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/842316

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/842317

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/842318

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/842319

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on kolla-ansible (stable/yoga)

Change abandoned by "Piotr Parczewski <email address hidden>" on branch: stable/yoga
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/842316
Reason: mistake, already exists for Yoga

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/842317
Committed: https://opendev.org/openstack/kolla-ansible/commit/7525f1e08a2e8ae041c7e17286d3611d1ef24dd3
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 7525f1e08a2e8ae041c7e17286d3611d1ef24dd3
Author: Uwe Grawert <email address hidden>
Date: Fri Oct 8 12:15:36 2021 +0200

    Grafana: Run priviliged when copying home dashboard file

    The copy job for the grafana home dashboard file needs to run
    priviliged, otherwise permission denied error occurs.

    Closes-Bug: #1947710

    Change-Id: Ib15e961e5193af55e45a443305a96667295f3cb7
    (cherry picked from commit 82b0e095a56a9707268f83484292589902ab1c8a)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/842318
Committed: https://opendev.org/openstack/kolla-ansible/commit/3d25b71694498046ba052afe4324a520f6cf7949
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 3d25b71694498046ba052afe4324a520f6cf7949
Author: Uwe Grawert <email address hidden>
Date: Fri Oct 8 12:15:36 2021 +0200

    Grafana: Run priviliged when copying home dashboard file

    The copy job for the grafana home dashboard file needs to run
    priviliged, otherwise permission denied error occurs.

    Closes-Bug: #1947710

    Change-Id: Ib15e961e5193af55e45a443305a96667295f3cb7
    (cherry picked from commit 82b0e095a56a9707268f83484292589902ab1c8a)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/842319
Committed: https://opendev.org/openstack/kolla-ansible/commit/317fa22a8f3ad1c3d5b7d66577849ecd3957a8ee
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 317fa22a8f3ad1c3d5b7d66577849ecd3957a8ee
Author: Uwe Grawert <email address hidden>
Date: Fri Oct 8 12:15:36 2021 +0200

    Grafana: Run priviliged when copying home dashboard file

    The copy job for the grafana home dashboard file needs to run
    priviliged, otherwise permission denied error occurs.

    Closes-Bug: #1947710

    Change-Id: Ib15e961e5193af55e45a443305a96667295f3cb7
    (cherry picked from commit 82b0e095a56a9707268f83484292589902ab1c8a)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 12.4.0

This issue was fixed in the openstack/kolla-ansible 12.4.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 13.1.0

This issue was fixed in the openstack/kolla-ansible 13.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible victoria-eol

This issue was fixed in the openstack/kolla-ansible victoria-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.