kolla-ansible

External_labels in default Prometheus config

Bug #1944699 reported by Piotr Parczewski
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla-ansible
Fix Released
Undecided
zhangmeng

Bug Description

It's unlclear why monitor: kolla has been added in the first place. Default config should be free of any user-specific or environment-specific details.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/810605

Changed in kolla-ansible:
status: New → In Progress
zhangmeng (minguk)
Changed in kolla-ansible:
assignee: nobody → zhangmeng (minguk)
Revision history for this message
zhangmeng (minguk) wrote :

Maybe we could make "external_labels" optional instead of just removing it

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/850446

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (master)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/850446
Committed: https://opendev.org/openstack/kolla-ansible/commit/41a9402910cee9ccea9808c2140038c76500416d
Submitter: "Zuul (22348)"
Branch: master

commit 41a9402910cee9ccea9808c2140038c76500416d
Author: zhangmeng <zhang.meng@99cloud.net>
Date: Wed Jul 20 10:01:25 2022 +0800

    make "external_labels" optional on prometheus.yml

    Closes-bug: 1944699
    Change-Id: I6d0bb3b88983846fdd9c8af09456a106a940d191

Changed in kolla-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on kolla-ansible (master)

Change abandoned by "Piotr Parczewski <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/810605

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 15.0.0.0rc1

This issue was fixed in the openstack/kolla-ansible 15.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.