node_custom_config doesn't honor --configdir

[Scott Shambarger]

The default for node_custom_config does not use node_config, which may be overriden with --configdir, and is defaulted to "/etc/kolla/config". Since the files are used to template with the globals.yml values, it makes sense that they should be grouped with the globals.yml file, at least by default.

Of course, working around the default is as easy as setting

 node_custom_config: "{{ node_config }}/config"

in the globals.yml -- but the name similarity implies that node_config and node_custom_config should refer to the same "group" of configurations... and I was surprised when --configdir didn't apply to the custom files.

[Mark Goddard (mgoddard)]

I agree that your suggestion is more intuitive than how it currently works. My only concern is around backwards compatibility, and whether it might break existing users. I suppose they would have to be using the default for node_custom_config (/etc/kolla/config), while using a different --configdir than /etc/kolla, which would be quite unusual.