kolla-ansible

kolla-ansible exits 0 with a bogus command

Bug #1929397 reported by Mark Goddard
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla-ansible
Fix Released
Medium
Unassigned
Train
New
Medium
Unassigned
Ussuri
Fix Committed
Medium
Unassigned
Victoria
Fix Committed
Medium
Unassigned
Wallaby
Fix Committed
Medium
Unassigned
Xena
Fix Released
Medium
Unassigned

Bug Description

# Steps to reproduce

kolla-ansible bogus-command

# Expected results

Usage & non-zero exit code

# Actual results

Usage & zero exit code

Mark Goddard (mgoddard)
Changed in kolla-ansible:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/792799

Changed in kolla-ansible:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (master)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/792799
Committed: https://opendev.org/openstack/kolla-ansible/commit/86ddc94ec2f6ec46d6dfc4feeb58c12aaabcd252
Submitter: "Zuul (22348)"
Branch: master

commit 86ddc94ec2f6ec46d6dfc4feeb58c12aaabcd252
Author: Mark Goddard <email address hidden>
Date: Mon May 24 10:52:43 2021 +0100

    Fix exit code with bogus command name

    Running this:

    $ kolla-ansible bogus-command

    Should show usage & give a non-zero exit code. Previously it gave a zero
    exit code. This change fixes the issue.

    Closes-Bug: #1929397

    Change-Id: I580c208d61d5efe115f936dfb8f3f6508acd91b2

Changed in kolla-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/802209

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/802210

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/802211

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/802209
Committed: https://opendev.org/openstack/kolla-ansible/commit/8c68ced1a240fd74c1d3be8e9dfcf69693fe0ad1
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 8c68ced1a240fd74c1d3be8e9dfcf69693fe0ad1
Author: Mark Goddard <email address hidden>
Date: Mon May 24 10:52:43 2021 +0100

    Fix exit code with bogus command name

    Running this:

    $ kolla-ansible bogus-command

    Should show usage & give a non-zero exit code. Previously it gave a zero
    exit code. This change fixes the issue.

    Closes-Bug: #1929397

    Change-Id: I580c208d61d5efe115f936dfb8f3f6508acd91b2
    (cherry picked from commit 86ddc94ec2f6ec46d6dfc4feeb58c12aaabcd252)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/802210
Committed: https://opendev.org/openstack/kolla-ansible/commit/51eac17b4dbf0de78c7f20752e7644d35a370317
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 51eac17b4dbf0de78c7f20752e7644d35a370317
Author: Mark Goddard <email address hidden>
Date: Mon May 24 10:52:43 2021 +0100

    Fix exit code with bogus command name

    Running this:

    $ kolla-ansible bogus-command

    Should show usage & give a non-zero exit code. Previously it gave a zero
    exit code. This change fixes the issue.

    Closes-Bug: #1929397

    Change-Id: I580c208d61d5efe115f936dfb8f3f6508acd91b2
    (cherry picked from commit 86ddc94ec2f6ec46d6dfc4feeb58c12aaabcd252)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/802211
Committed: https://opendev.org/openstack/kolla-ansible/commit/588e7e87c3fba93346b175d4c1d57845e36c5584
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 588e7e87c3fba93346b175d4c1d57845e36c5584
Author: Mark Goddard <email address hidden>
Date: Mon May 24 10:52:43 2021 +0100

    Fix exit code with bogus command name

    Running this:

    $ kolla-ansible bogus-command

    Should show usage & give a non-zero exit code. Previously it gave a zero
    exit code. This change fixes the issue.

    Closes-Bug: #1929397

    Change-Id: I580c208d61d5efe115f936dfb8f3f6508acd91b2
    (cherry picked from commit 86ddc94ec2f6ec46d6dfc4feeb58c12aaabcd252)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 11.1.0

This issue was fixed in the openstack/kolla-ansible 11.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 12.1.0

This issue was fixed in the openstack/kolla-ansible 12.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 10.3.0

This issue was fixed in the openstack/kolla-ansible 10.3.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 13.0.0.0rc1

This issue was fixed in the openstack/kolla-ansible 13.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.