docker sdk 5.0.0 fails due to missing six

Bug #1928915 reported by Michal Nasiadka
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
kolla-ansible
Fix Released
Critical
Michal Nasiadka
Train
Fix Committed
Critical
Unassigned
Ussuri
Fix Committed
Critical
Unassigned
Victoria
Fix Committed
Critical
Unassigned
Wallaby
Fix Committed
Critical
Unassigned
Xena
Fix Released
Critical
Michal Nasiadka

Bug Description

docker python SDK 5.0.0 has removed dependency for six, but still imports that in code

Example of failure in prechecks:

TASK [prechecks : Checking docker SDK version] *********************************
task path: /home/zuul/src/opendev.org/openstack/kolla-ansible/ansible/roles/prechecks/tasks/package_checks.yml:2
Using module file /home/zuul/.local/lib/python3.6/site-packages/ansible/modules/commands/command.py
Pipelining is enabled.
<158.69.70.206> ESTABLISH SSH CONNECTION FOR USER: kolla
<158.69.70.206> SSH: EXEC ssh -C -o ControlMaster=auto -o ControlPersist=60s -o StrictHostKeyChecking=no -o 'IdentityFile="/home/zuul/.ssh/id_rsa_kolla"' -o KbdInteractiveAuthentication=no -o PreferredAuthentications=gssapi-with-mic,gssapi-keyex,hostbased,publickey -o PasswordAuthentication=no -o 'User="kolla"' -o ConnectTimeout=10 -o ControlPath=/home/zuul/.ansible/cp/492ee742d8 158.69.70.206 '/bin/sh -c '"'"'/usr/bin/python3 && sleep 0'"'"''
<158.69.70.206> (1, b'\n{"msg": "non-zero return code", "cmd": ["/usr/bin/python3", "-c", "import docker; print(docker.__version__)"], "stdout": "", "stderr": "Traceback (most recent call last):\\n File \\"<string>\\", line 1, in <module>\\n File \\"/usr/local/lib/python3.6/dist-packages/docker/__init__.py\\", line 2, in <module>\\n from .api import APIClient\\n File \\"/usr/local/lib/python3.6/dist-packages/docker/api/__init__.py\\", line 2, in <module>\\n from .client import APIClient\\n File \\"/usr/local/lib/python3.6/dist-packages/docker/api/client.py\\", line 10, in <module>\\n from .. import auth\\n File \\"/usr/local/lib/python3.6/dist-packages/docker/auth.py\\", line 5, in <module>\\n import six\\nModuleNotFoundError: No module named \'six\'", "rc": 1, "start": "2021-05-18 11:42:52.208094", "end": "2021-05-18 11:42:52.365473", "delta": "0:00:00.157379", "changed": true, "failed": true, "invocation": {"module_args": {"_raw_params": "/usr/bin/python3 -c \\"import docker; print(docker.__version__)\\"", "warn": true, "_uses_shell": false, "stdin_add_newline": true, "strip_empty_ends": true, "argv": null, "chdir": null, "executable": null, "creates": null, "removes": null, "stdin": null}}}\n', b'')
<158.69.70.206> Failed to connect to the host via ssh:
fatal: [primary]: FAILED! => {
    "changed": false,
    "cmd": [
        "/usr/bin/python3",
        "-c",
        "import docker; print(docker.__version__)"
    ],
    "delta": "0:00:00.157379",
    "end": "2021-05-18 11:42:52.365473",
    "failed_when_result": true,
    "invocation": {
        "module_args": {
            "_raw_params": "/usr/bin/python3 -c \"import docker; print(docker.__version__)\"",
            "_uses_shell": false,
            "argv": null,
            "chdir": null,
            "creates": null,
            "executable": null,
            "removes": null,
            "stdin": null,
            "stdin_add_newline": true,
            "strip_empty_ends": true,
            "warn": true
        }
    },
    "msg": "non-zero return code",
    "rc": 1,
    "start": "2021-05-18 11:42:52.208094",
    "stderr": "Traceback (most recent call last):\n File \"<string>\", line 1, in <module>\n File \"/usr/local/lib/python3.6/dist-packages/docker/__init__.py\", line 2, in <module>\n from .api import APIClient\n File \"/usr/local/lib/python3.6/dist-packages/docker/api/__init__.py\", line 2, in <module>\n from .client import APIClient\n File \"/usr/local/lib/python3.6/dist-packages/docker/api/client.py\", line 10, in <module>\n from .. import auth\n File \"/usr/local/lib/python3.6/dist-packages/docker/auth.py\", line 5, in <module>\n import six\nModuleNotFoundError: No module named 'six'",
    "stderr_lines": [
        "Traceback (most recent call last):",
        " File \"<string>\", line 1, in <module>",
        " File \"/usr/local/lib/python3.6/dist-packages/docker/__init__.py\", line 2, in <module>",
        " from .api import APIClient",
        " File \"/usr/local/lib/python3.6/dist-packages/docker/api/__init__.py\", line 2, in <module>",
        " from .client import APIClient",
        " File \"/usr/local/lib/python3.6/dist-packages/docker/api/client.py\", line 10, in <module>",
        " from .. import auth",
        " File \"/usr/local/lib/python3.6/dist-packages/docker/auth.py\", line 5, in <module>",
        " import six",
        "ModuleNotFoundError: No module named 'six'"
    ],
    "stdout": "",
    "stdout_lines": []
}

Issue in GitHub: https://github.com/docker/docker-py/issues/2807

Changed in kolla-ansible:
status: New → Confirmed
importance: Undecided → Critical
assignee: nobody → Michal Nasiadka (mnasiadka)
Changed in kolla-ansible:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (master)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/792071
Committed: https://opendev.org/openstack/kolla-ansible/commit/b053bd8ecf2cdbbdf83aeb6777e9502e5db70256
Submitter: "Zuul (22348)"
Branch: master

commit b053bd8ecf2cdbbdf83aeb6777e9502e5db70256
Author: Michał Nasiadka <email address hidden>
Date: Wed May 19 08:08:42 2021 +0200

    baremetal: Install Docker SDK less than 5.0.0

    Docker 5.0.0 [1] dropped requirement for six, but still imports it.

    [1]: https://github.com/docker/docker-py/issues/2807

    Closes-Bug: #1928915
    Change-Id: I726541f4b3fdc357387a44c6a2153593a10bf282

Changed in kolla-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/792110

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/792115

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/792157

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/792158

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/792110
Committed: https://opendev.org/openstack/kolla-ansible/commit/ee8bd456bdad0b44f572ee62733259b8bb86dfb5
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit ee8bd456bdad0b44f572ee62733259b8bb86dfb5
Author: Michał Nasiadka <email address hidden>
Date: Wed May 19 08:08:42 2021 +0200

    baremetal: Install Docker SDK less than 5.0.0

    Docker 5.0.0 [1] dropped requirement for six, but still imports it.

    [1]: https://github.com/docker/docker-py/issues/2807

    Closes-Bug: #1928915
    Change-Id: I726541f4b3fdc357387a44c6a2153593a10bf282
    (cherry picked from commit b053bd8ecf2cdbbdf83aeb6777e9502e5db70256)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/train)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/792158
Committed: https://opendev.org/openstack/kolla-ansible/commit/56eefd8c429433480de5925d841de27d40c655e0
Submitter: "Zuul (22348)"
Branch: stable/train

commit 56eefd8c429433480de5925d841de27d40c655e0
Author: Michał Nasiadka <email address hidden>
Date: Wed May 19 08:08:42 2021 +0200

    baremetal: Install Docker SDK less than 5.0.0

    Docker 5.0.0 [1] dropped requirement for six, but still imports it.

    [1]: https://github.com/docker/docker-py/issues/2807

    Closes-Bug: #1928915
    Change-Id: I726541f4b3fdc357387a44c6a2153593a10bf282
    (cherry picked from commit b053bd8ecf2cdbbdf83aeb6777e9502e5db70256)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/792157
Committed: https://opendev.org/openstack/kolla-ansible/commit/b97b388bd10ae39a54f7942340b58125c2b8670a
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit b97b388bd10ae39a54f7942340b58125c2b8670a
Author: Michał Nasiadka <email address hidden>
Date: Wed May 19 08:08:42 2021 +0200

    baremetal: Install Docker SDK less than 5.0.0

    Docker 5.0.0 [1] dropped requirement for six, but still imports it.

    [1]: https://github.com/docker/docker-py/issues/2807

    Closes-Bug: #1928915
    Change-Id: I726541f4b3fdc357387a44c6a2153593a10bf282
    (cherry picked from commit b053bd8ecf2cdbbdf83aeb6777e9502e5db70256)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/792115
Committed: https://opendev.org/openstack/kolla-ansible/commit/5ef58708c61b26767c341566249664e693328c51
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 5ef58708c61b26767c341566249664e693328c51
Author: Michał Nasiadka <email address hidden>
Date: Wed May 19 08:08:42 2021 +0200

    baremetal: Install Docker SDK less than 5.0.0

    Docker 5.0.0 [1] dropped requirement for six, but still imports it.

    [1]: https://github.com/docker/docker-py/issues/2807

    Closes-Bug: #1928915
    Change-Id: I726541f4b3fdc357387a44c6a2153593a10bf282
    (cherry picked from commit b053bd8ecf2cdbbdf83aeb6777e9502e5db70256)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 9.3.2

This issue was fixed in the openstack/kolla-ansible 9.3.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 12.0.0.0rc2

This issue was fixed in the openstack/kolla-ansible 12.0.0.0rc2 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 11.1.0

This issue was fixed in the openstack/kolla-ansible 11.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 10.3.0

This issue was fixed in the openstack/kolla-ansible 10.3.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 13.0.0.0rc1

This issue was fixed in the openstack/kolla-ansible 13.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.