Glance config missing from Manila.conf

[Kyle Dean]

**Bug Report**
Whats happening
NFS, CIFS deployment was failing

What i expected to happen
NFS server to be launched.

How to reproduce it:
Deploy kolla

Follow instructions here: https://docs.openstack.org/kolla-ansible/latest/reference/storage/manila-guide.html

**Environment**:
* OS Ubuntu
* Kernel 5.4.0-66
* Kolla-Ansible version: stable/victoria
* Docker image Install type: source
* Docker image distribution: ubuntu
* Are you using official images from Docker Hub or self built: self built
* Kolla version and environment used to build: stable/victoria

Description:
The following bug was found with the manila config. The glance section is missing from the manila.conf file

File: https://github.com/openstack/kolla-ansible/blob/master/ansible/roles/manila/templates/manila-share.conf.j2#L8-L58

I had to make the following changes to the manila.conf
[glance]
auth_url =
auth_type = password
project_domain_id = default
user_domain_id = default
region_name =
endpoint_type = internalURL
project_name = service
username = glance
password =
cafile = /etc/ssl/certs/ca-certificates.crt
project_domain_name = Default

Search for Glance section here: https://docs.openstack.org/manila/victoria/configuration/shared-file-systems/samples/manila.conf.html

Related: https://bugs.launchpad.net/manila/+bug/1921927

Kind regards,

Kyle

[Mark Goddard (mgoddard)]

Hi Kyle, are you able to propose a fix for this issue?

[Kyle Dean (k.s-dean)]

Just add the glance section into your manila template file.
https://github.com/openstack/kolla-ansible/blob/master/ansible/roles/manila/templates/manila-share.conf.j2#L8-L58

[glance]
auth_url = {{ keystone_admin_url }}
auth_type = password
project_domain_id = {{ default_project_domain_id }}
user_domain_id = {{ default_user_domain_id }}
region_name = {{ openstack_region_name }}
endpoint_type = internalURL
project_name = service
username = {{ neutron_keystone_user }}
password = {{ neutron_keystone_password }}
cafile = {{ openstack_cacert }}

[Mark Goddard (mgoddard)]

What I meant was, are you planning to propose a patch to gerrit to fix this?

[Kyle Dean (k.s-dean)]

Ok. I'll propose a fix and upload this to gerrit on opendev. Put you as the reviewer.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/787346
Committed: https://opendev.org/openstack/kolla-ansible/commit/2e4f51f671b4e14fd58a67f1a22106c09c037eed
Submitter: "Zuul (22348)"
Branch: master

commit 2e4f51f671b4e14fd58a67f1a22106c09c037eed
Author: Kyle Dean <email address hidden>
Date: Wed Apr 21 12:00:20 2021 +0100

    manila: add glance section in manila-share.conf

    Since the Victoria release, manila-share.conf requires a glance section
    for some drivers. This change adds the missing section.

    It also uses the correct cinder_keystone_user variable to reference the
    cinder user.

    Closes-Bug: #1921935

    Change-Id: Ib7ce4ed79c28456281087eb4156577f910c072e7

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/802783

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/802784

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/802785

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/802785
Committed: https://opendev.org/openstack/kolla-ansible/commit/43c81db1cab129e0844b80b99e7fd89e6bef35f8
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 43c81db1cab129e0844b80b99e7fd89e6bef35f8
Author: Kyle Dean <email address hidden>
Date: Wed Apr 21 12:00:20 2021 +0100

    manila: add glance section in manila-share.conf

    Since the Victoria release, manila-share.conf requires a glance section
    for some drivers. This change adds the missing section.

    It also uses the correct cinder_keystone_user variable to reference the
    cinder user.

    Closes-Bug: #1921935

    Change-Id: Ib7ce4ed79c28456281087eb4156577f910c072e7
    (cherry picked from commit 2e4f51f671b4e14fd58a67f1a22106c09c037eed)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/802783
Committed: https://opendev.org/openstack/kolla-ansible/commit/7ae560fe273939417e4352fc740cb99f4a769f6c
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 7ae560fe273939417e4352fc740cb99f4a769f6c
Author: Kyle Dean <email address hidden>
Date: Wed Apr 21 12:00:20 2021 +0100

    manila: add glance section in manila-share.conf

    Since the Victoria release, manila-share.conf requires a glance section
    for some drivers. This change adds the missing section.

    It also uses the correct cinder_keystone_user variable to reference the
    cinder user.

    Closes-Bug: #1921935

    Change-Id: Ib7ce4ed79c28456281087eb4156577f910c072e7
    (cherry picked from commit 2e4f51f671b4e14fd58a67f1a22106c09c037eed)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/802784
Committed: https://opendev.org/openstack/kolla-ansible/commit/b710fef049ec673c1a0966f28f5dd8c792fbfd4a
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit b710fef049ec673c1a0966f28f5dd8c792fbfd4a
Author: Kyle Dean <email address hidden>
Date: Wed Apr 21 12:00:20 2021 +0100

    manila: add glance section in manila-share.conf

    Since the Victoria release, manila-share.conf requires a glance section
    for some drivers. This change adds the missing section.

    It also uses the correct cinder_keystone_user variable to reference the
    cinder user.

    Closes-Bug: #1921935

    Change-Id: Ib7ce4ed79c28456281087eb4156577f910c072e7
    (cherry picked from commit 2e4f51f671b4e14fd58a67f1a22106c09c037eed)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla-ansible 12.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla-ansible 13.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla-ansible 10.4.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla-ansible 11.2.0 release.