Fluentd fails to deploy on Stein with change to image but not config

[Mark Goddard]

* Deploy fluentd using stable/stein
* Pull down a different fluentd image
* Deploy again

RUNNING HANDLER [common : Restart fluentd container] ************************************************************
fatal: [controller0]: FAILED! => {"msg": "The conditional check 'config_json.changed | bool or fluentd_input.changed | bool or fluentd_input_custom.changed | bool or fluentd_output.changed | bool or fluentd_output_custom.changed | bool or fluentd_format.changed | bool or fluentd_format_custom.changed | bool or fluentd_filter.changed | bool or fluentd_filter_custom.changed | bool or fluentd_td_agent.changed | bool or fluentd_container.changed | bool' failed. The error was: error while evaluating conditional (config_json.changed | bool or fluentd_input.changed | bool or fluentd_input_custom.changed | bool or fluentd_output.changed | bool or fluentd_output_custom.changed | bool or fluentd_format.changed | bool or fluentd_format_custom.changed | bool or fluentd_filter.changed | bool or fluentd_filter_custom.changed | bool or fluentd_td_agent.changed | bool or fluentd_container.changed | bool): 'fluentd_input' is undefined\n\nThe error appears to have been in '/home/centos/kolla-venv/share/kolla-ansible/ansible/roles/common/handlers/main.yml': line 2, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n---\n- name: Restart fluentd container\n ^ here\n"}

This was introduced by https://review.opendev.org/#/c/757817/, which did not update the handlers.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/763155

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/763155
Committed: https://opendev.org/openstack/kolla-ansible/commit/7467b7db959b160a2a404f61a318a2d9740dc2e7
Submitter: Zuul
Branch: stable/stein

commit 7467b7db959b160a2a404f61a318a2d9740dc2e7
Author: Mark Goddard <email address hidden>
Date: Wed Nov 18 10:39:27 2020 +0000

    fluentd: Remove conditions from handler

    Stein only

    In https://review.opendev.org/#/c/757817/, the fluentd configuration
    generation was simplified to write out a single file. This removed 8
    different registered variables, however these were not removed from the
    handler condition. If the image is updated but configuration is not,
    then the user will get the following error:

      'fluentd_input' is undefined

    This change removes the variables from the handler condition.

    Closes-Bug: #1904721

    Change-Id: I5aa29fdb4f78c981deb53a9d40dad148c7d40849

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla-ansible 8.3.0 release.