kolla-ansible

post-deploy different behaviour with new ansible versions

Bug #1891145 reported by Radosław Piliszek
This bug report is a duplicate of:  Bug #1891704: admin-openrc.sh is world readable. Edit Remove
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla-ansible
Triaged
Critical
Radosław Piliszek
Stein
Triaged
Critical
Unassigned
Train
Triaged
Critical
Unassigned
Ussuri
Triaged
Critical
Unassigned
Victoria
Triaged
Critical
Radosław Piliszek

Bug Description

Stable Ansible versions got backport from Ansible 2.11 [1] which changes the default mode for files created by Ansible. It affects versions 2.8.14 and 2.9.12 so far.

CI is RED due to this affecting post-deploy action.
There could be more such defaults around but it's not easy to grep.

[1] https://github.com/ansible/ansible/pull/70221

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (master)

Fix proposed to branch: master
Review: https://review.opendev.org/745648

Revision history for this message
Radosław Piliszek (yoctozepto) wrote :

reported upstream too: https://github.com/ansible/ansible/issues/71200

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to kolla-ansible (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/745652

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to kolla-ansible (stable/ussuri)

Related fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/745659

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on kolla-ansible (master)

Change abandoned by Radosław Piliszek (<email address hidden>) on branch: master
Review: https://review.opendev.org/745652
Reason: needs to go with https://review.opendev.org/743502 on master

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to kolla-ansible (master)

Reviewed: https://review.opendev.org/743502
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=352f91ac1077d557d833b199cb5a5d489e96437f
Submitter: Zuul
Branch: master

commit 352f91ac1077d557d833b199cb5a5d489e96437f
Author: Marcin Juszkiewicz <email address hidden>
Date: Tue Jul 28 12:07:51 2020 +0200

    ubuntu: move to 20.04 Focal

    There is a time once every 2 years when ubuntu team releases new LTS
    release. And then UCA joins with binary packages for current OpenStack
    development cycle.

    It is this time for Ubuntu 20.04 'focal'.

    Includes CI fix to pass:

    [CI] Temporarily block new Ansible

    The proper fix [1] needs fixing older branches before newer.
    This one allows to fix CI first, in the usual order.

    To revert after [1] gets merged in all relevant branches.

    [1] https://review.opendev.org/745648

    Old-Change-Id: Ifbd37d8addd4322773118e2e9d46494741a8ae66
    Related-Bug: #1891145

    Depends-on: https://review.opendev.org/#/c/738994/
    Change-Id: Ib8b70ee40ec2d19509cc84c0f530612f81907721
    Co-Authored-By: Radosław Piliszek <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to kolla-ansible (stable/ussuri)

Reviewed: https://review.opendev.org/745659
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=b2a30ab500c6601987b2943eeed3430072a12bf5
Submitter: Zuul
Branch: stable/ussuri

commit b2a30ab500c6601987b2943eeed3430072a12bf5
Author: Radosław Piliszek <email address hidden>
Date: Tue Aug 11 12:52:36 2020 +0200

    [CI] Temporarily block new Ansible

    The proper fix [1] needs fixing older branches before newer.
    This one allows to fix CI first, in the usual order.

    To revert after [1] gets merged in all relevant branches.

    [1] https://review.opendev.org/745648

    Change-Id: Ifbd37d8addd4322773118e2e9d46494741a8ae66
    Related-Bug: #1891145

tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (master)

Reviewed: https://review.opendev.org/745648
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=87efdce24bc802777d4da58f9f63c8d0838e7120
Submitter: Zuul
Branch: master

commit 87efdce24bc802777d4da58f9f63c8d0838e7120
Author: Radosław Piliszek <email address hidden>
Date: Tue Aug 11 12:12:10 2020 +0200

    Fix post-deploy mode

    Ansible changed the default mode for files, even in stable
    releases. [1]

    This change restores the previous default (with the common
    umask).

    [1] https://github.com/ansible/ansible/pull/70221

    Change-Id: I0f81214b4f95fe8a378844745ebc77f3c43027ab
    Closes-Bug: #1891145

Changed in kolla-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to kolla-ansible (stable/train)

Related fix proposed to branch: stable/train
Review: https://review.opendev.org/745805

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to kolla-ansible (stable/stein)

Related fix proposed to branch: stable/stein
Review: https://review.opendev.org/745807

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to kolla-ansible (stable/rocky)

Related fix proposed to branch: stable/rocky
Review: https://review.opendev.org/745808

Revision history for this message
Radosław Piliszek (yoctozepto) wrote :

ansible-lint is getting support for it: https://github.com/ansible/ansible-lint/pull/943

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to kolla-ansible (stable/train)

Reviewed: https://review.opendev.org/745805
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=cf733fdde6a9c23ecc875a4c7c06bf32ff41b826
Submitter: Zuul
Branch: stable/train

commit cf733fdde6a9c23ecc875a4c7c06bf32ff41b826
Author: Radosław Piliszek <email address hidden>
Date: Tue Aug 11 12:52:36 2020 +0200

    [CI] Temporarily block new Ansible

    The proper fix [1] needs fixing older branches before newer.
    This one allows to fix CI first, in the usual order.

    To revert after [1] gets merged in all relevant branches.

    [1] https://review.opendev.org/745648

    Change-Id: Ifbd37d8addd4322773118e2e9d46494741a8ae66
    Related-Bug: #1891145
    (cherry picked from commit b2a30ab500c6601987b2943eeed3430072a12bf5)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to kolla-ansible (stable/stein)

Reviewed: https://review.opendev.org/745807
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=460066721c6ae2101edd5c03fee5b2d34108f52f
Submitter: Zuul
Branch: stable/stein

commit 460066721c6ae2101edd5c03fee5b2d34108f52f
Author: Radosław Piliszek <email address hidden>
Date: Tue Aug 11 12:52:36 2020 +0200

    [CI] Temporarily block new Ansible

    The proper fix [1] needs fixing older branches before newer.
    This one allows to fix CI first, in the usual order.

    To revert after [1] gets merged in all relevant branches.

    [1] https://review.opendev.org/745648

    Change-Id: Ifbd37d8addd4322773118e2e9d46494741a8ae66
    Related-Bug: #1891145
    (cherry picked from commit b2a30ab500c6601987b2943eeed3430072a12bf5)
    (cherry picked from commit cf733fdde6a9c23ecc875a4c7c06bf32ff41b826)

tags: added: in-stable-stein
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to kolla-ansible (stable/rocky)

Reviewed: https://review.opendev.org/745808
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=e71912042ce674da91de5c87fcfb11a8e7b7414e
Submitter: Zuul
Branch: stable/rocky

commit e71912042ce674da91de5c87fcfb11a8e7b7414e
Author: Radosław Piliszek <email address hidden>
Date: Tue Aug 11 12:52:36 2020 +0200

    [CI] Temporarily block new Ansible

    The proper fix [1] needs fixing older branches before newer.
    This one allows to fix CI first, in the usual order.

    To revert after [1] gets merged in all relevant branches.

    [1] https://review.opendev.org/745648

    Change-Id: Ifbd37d8addd4322773118e2e9d46494741a8ae66
    Related-Bug: #1891145
    (cherry picked from commit b2a30ab500c6601987b2943eeed3430072a12bf5)
    (cherry picked from commit cf733fdde6a9c23ecc875a4c7c06bf32ff41b826)
    (cherry picked from commit 460066721c6ae2101edd5c03fee5b2d34108f52f)

tags: added: in-stable-rocky
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.