check failed when the host is Centos but the kolla_base_distro is ubuntu

[wu.chunyang]

host os: centos8.0
kolla_base_distro: ubuntu

kolla-ansible prechecks

TASK [prechecks : Fail if /etc/timezone is absent] *****************************************************************************************************************************************************************************************************************************
fatal: [localhost]: FAILED! => {"changed": false, "msg": "/etc/timezone is not found. This file is used for system-wide timezone settings and Kolla Ansible needs this file for mounting it to containers."}

centos doesn't have /etc/timezone. timezone info is in /etc/localtime, we can use timedatectl to control it. but ubuntu is different.

i think we should create this file when host is centos but kolla_base_distro is ubuntu. and delete this file when destroy.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/745505

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/745505
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=146b00efa7081eac9cba4410b5ea7e8b17535246
Submitter: Zuul
Branch: master

commit 146b00efa7081eac9cba4410b5ea7e8b17535246
Author: Mark Goddard <email address hidden>
Date: Mon Aug 10 09:33:00 2020 +0100

    Mount /etc/timezone based on host OS

    Previously we mounted /etc/timezone if the kolla_base_distro is debian
    or ubuntu. This would fail prechecks if debian or ubuntu images were
    deployed on CentOS. While this is not a supported combination, for
    correctness we should fix the condition to reference the host OS rather
    than the container OS, since that is where the /etc/timezone file is
    located.

    Change-Id: Ifc252ae793e6974356fcdca810b373f362d24ba5
    Closes-Bug: #1882553

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/746017

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/746018

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/746791

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/746018
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=84ccebf1649b3e3c59c6c69872560130e12d44c8
Submitter: Zuul
Branch: stable/train

commit 84ccebf1649b3e3c59c6c69872560130e12d44c8
Author: Mark Goddard <email address hidden>
Date: Mon Aug 10 09:33:00 2020 +0100

    Mount /etc/timezone based on host OS

    Backport adapted for Train.

    Previously we mounted /etc/timezone if the kolla_base_distro is debian
    or ubuntu. This would fail prechecks if debian or ubuntu images were
    deployed on CentOS. While this is not a supported combination, for
    correctness we should fix the condition to reference the host OS rather
    than the container OS, since that is where the /etc/timezone file is
    located.

    Change-Id: Ifc252ae793e6974356fcdca810b373f362d24ba5
    Closes-Bug: #1882553
    (cherry picked from commit 146b00efa7081eac9cba4410b5ea7e8b17535246)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/747527

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/747527
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=0c3d9885304299def6133986a1cfd51b1c2bbc3b
Submitter: Zuul
Branch: master

commit 0c3d9885304299def6133986a1cfd51b1c2bbc3b
Author: wu.chunyang <email address hidden>
Date: Sat Aug 22 21:35:58 2020 +0800

    change the timezone precheck task's condition

    this ps[0] uses new condition for timezone mounting
    but we missed prechecks condition.

    [0] https://review.opendev.org/#/c/745505/

    Change-Id: I79323a392e171bebe36d06c19d34e458e05e194b
    Closes-Bug: #1882553

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/747679

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/747680

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/747681

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/747679
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=c30eb14aff0306437372d775bba0b5a620633196
Submitter: Zuul
Branch: stable/ussuri

commit c30eb14aff0306437372d775bba0b5a620633196
Author: wu.chunyang <email address hidden>
Date: Sat Aug 22 21:35:58 2020 +0800

    change the timezone precheck task's condition

    this ps[0] uses new condition for timezone mounting
    but we missed prechecks condition.

    [0] https://review.opendev.org/#/c/745505/

    Change-Id: I79323a392e171bebe36d06c19d34e458e05e194b
    Closes-Bug: #1882553
    (cherry picked from commit 0c3d9885304299def6133986a1cfd51b1c2bbc3b)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/747680
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=1ae811932689718b038d3cc3cc8c9a9e5f8df48b
Submitter: Zuul
Branch: stable/train

commit 1ae811932689718b038d3cc3cc8c9a9e5f8df48b
Author: wu.chunyang <email address hidden>
Date: Sat Aug 22 21:35:58 2020 +0800

    change the timezone precheck task's condition

    this ps[0] uses new condition for timezone mounting
    but we missed prechecks condition.

    [0] https://review.opendev.org/#/c/745505/

    Change-Id: I79323a392e171bebe36d06c19d34e458e05e194b
    Closes-Bug: #1882553
    (cherry picked from commit 0c3d9885304299def6133986a1cfd51b1c2bbc3b)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/747681
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=7f7b8a3349783acb3c7b95884fde700ceeed7b3d
Submitter: Zuul
Branch: stable/stein

commit 7f7b8a3349783acb3c7b95884fde700ceeed7b3d
Author: wu.chunyang <email address hidden>
Date: Sat Aug 22 21:35:58 2020 +0800

    change the timezone precheck task's condition

    this ps[0] uses new condition for timezone mounting
    but we missed prechecks condition.

    [0] https://review.opendev.org/#/c/745505/

    Change-Id: I79323a392e171bebe36d06c19d34e458e05e194b
    Closes-Bug: #1882553
    (cherry picked from commit 0c3d9885304299def6133986a1cfd51b1c2bbc3b)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/746017
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=a229bbd22a4e321ee620c9dfa70c1e879c83e718
Submitter: Zuul
Branch: stable/ussuri

commit a229bbd22a4e321ee620c9dfa70c1e879c83e718
Author: Mark Goddard <email address hidden>
Date: Mon Aug 10 09:33:00 2020 +0100

    Mount /etc/timezone based on host OS

    Previously we mounted /etc/timezone if the kolla_base_distro is debian
    or ubuntu. This would fail prechecks if debian or ubuntu images were
    deployed on CentOS. While this is not a supported combination, for
    correctness we should fix the condition to reference the host OS rather
    than the container OS, since that is where the /etc/timezone file is
    located.

    Change-Id: Ifc252ae793e6974356fcdca810b373f362d24ba5
    Closes-Bug: #1882553
    (cherry picked from commit 146b00efa7081eac9cba4410b5ea7e8b17535246)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/746791
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=479fb85d0d90eda15ed7b8770f756373ffc3d0bc
Submitter: Zuul
Branch: master

commit 479fb85d0d90eda15ed7b8770f756373ffc3d0bc
Author: Radosław Piliszek <email address hidden>
Date: Tue Aug 18 21:27:55 2020 +0200

    Fix tz handling for newly introduced services

    We missed to ensure new neutron switch use the new condition for
    timezone file mounting.

    Change-Id: I838e526b930d5276d3ce24f5188262af7eb33280
    Closes-Bug: #1882553

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla-ansible 8.3.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla-ansible 10.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla-ansible 9.3.0 release.