Ansible 2.9.8 breaks HAProxy configuration on fresh deploy

[Mark Goddard]

Due to https://github.com/ansible/ansible/issues/69450, an issue in Ansible's fileglob plugin. This affects Ubuntu CI jobs on master, which use the latest 2.9 release.

TASK [haproxy : Copying over custom haproxy services configuration] ************
task path: /home/zuul/src/opendev.org/openstack/kolla-ansible/ansible/roles/haproxy/tasks/config.yml:60
[WARNING]: Unable to find '/etc/kolla/config/haproxy/services.d' in expected
paths (use -vvvvv to see paths)
The full traceback is:
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/ansible/executor/task_executor.py", line 104, in run
    items = self._get_loop_items()
  File "/usr/local/lib/python3.6/dist-packages/ansible/executor/task_executor.py", line 245, in _get_loop_items
    items = wrap_var(mylookup.run(terms=loop_terms, variables=self._job_vars, wantlist=True))
  File "/usr/local/lib/python3.6/dist-packages/ansible/plugins/lookup/fileglob.py", line 75, in run
    globbed = glob.glob(to_bytes(os.path.join(dwimmed_path, term_file), errors='surrogate_or_strict'))
  File "/usr/lib/python3.6/posixpath.py", line 80, in join
    a = os.fspath(a)
TypeError: expected str, bytes or os.PathLike object, not NoneType
fatal: [primary]: FAILED! => {
    "msg": "Unexpected failure during module execution.",
    "stdout": ""
}

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/727163
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=100f92563fcf79d32df43c9c14b07744a2f98198
Submitter: Zuul
Branch: master

commit 100f92563fcf79d32df43c9c14b07744a2f98198
Author: Mark Goddard <email address hidden>
Date: Tue May 12 12:39:27 2020 +0100

    CI: Blacklist Ansible 2.9.8

    Ansible 2.9.8 includes a regression on the fileglob plugin [1] that
    causes the HAProxy role to fail.

    This change blacklists Ansible 2.9.8 to work around the issue.

    [1] https://github.com/ansible/ansible/issues/69450

    Change-Id: I12ca3b154fc7fed6a221880596e0acb5f6278bb7
    Related-Bug: #1878192

[Mark Goddard (mgoddard)]

Ansible 2.9.9 released including fix.