nova.conf override not used from documented location

Bug #1873782 reported by Raimund Hook
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla-ansible
Fix Released
Medium
Raimund Hook
Stein
Fix Released
Medium
Raimund Hook
Train
Fix Released
Medium
Radosław Piliszek
Ussuri
Fix Released
Medium
Raimund Hook

Bug Description

As documented here:

https://docs.openstack.org/kolla-ansible/latest/admin/advanced-configuration.html#openstack-service-configuration-in-kolla

An override file for nova.conf should work if placed under the path: /etc/kolla/config/nova/nova.conf

During kolla-ansible execution, the any file placed here is in fact _not_ picked up.

Changed in kolla-ansible:
assignee: nobody → Raimund Hook (stingrayza)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (master)

Fix proposed to branch: master
Review: https://review.opendev.org/721241

Changed in kolla-ansible:
status: New → In Progress
Revision history for this message
Raimund Hook (stingrayza) wrote :

From IRC:

stingrayza happy to fix this, - the question is do I just do a quick doc clean-up, or do we fix the conf pick up to additionally pick up "{{ node_custom_config }}/nova/nova.conf" ? (and if the latter, then do I do that for _all_ services?) 10:54
mgoddard stingrayza: I think typically we don't support that path, although there may be exceptions. Worth checking a few to be sure, but I'd update docs 11:08
stingrayza mgoddard: cool. doc update inbound :)

Mark Goddard (mgoddard)
Changed in kolla-ansible:
importance: Undecided → Medium
milestone: none → 10.0.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (master)

Reviewed: https://review.opendev.org/721241
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=08682243ed534366ff7ef52a538e14ad04d01f1c
Submitter: Zuul
Branch: master

commit 08682243ed534366ff7ef52a538e14ad04d01f1c
Author: Raimund Hook <email address hidden>
Date: Mon Apr 20 12:20:04 2020 +0100

    Update Advanced Config guide to clarify paths

    This update clears up an additional path that was mentioned in the
    Advanced Configuration documentation, but not actually picked up in the
    playbooks.

    This specifically affects Service Configuration overrides. The docs have
    been cleaned up to reflect the way the playbooks pick up the override
    files.

    Change-Id: Id15fe139af6462217c2ac26d7d21c5eac5368e12
    Closes-Bug: 1873782
    Signed-off-by: Raimund Hook <email address hidden>

Changed in kolla-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/726189

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/train)

Reviewed: https://review.opendev.org/726189
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=3efd5d6e190ae359b05ffa0e26cb28104cc6c8a2
Submitter: Zuul
Branch: stable/train

commit 3efd5d6e190ae359b05ffa0e26cb28104cc6c8a2
Author: Raimund Hook <email address hidden>
Date: Mon Apr 20 12:20:04 2020 +0100

    Update Advanced Config guide to clarify paths

    This update clears up an additional path that was mentioned in the
    Advanced Configuration documentation, but not actually picked up in the
    playbooks.

    This specifically affects Service Configuration overrides. The docs have
    been cleaned up to reflect the way the playbooks pick up the override
    files.

    Change-Id: Id15fe139af6462217c2ac26d7d21c5eac5368e12
    Closes-Bug: 1873782
    Signed-off-by: Raimund Hook <email address hidden>
    (cherry picked from commit 08682243ed534366ff7ef52a538e14ad04d01f1c)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/729218

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/stein)

Reviewed: https://review.opendev.org/729218
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=4b7dc5036bb4c83967a44ba15a5759400f6e27e1
Submitter: Zuul
Branch: stable/stein

commit 4b7dc5036bb4c83967a44ba15a5759400f6e27e1
Author: Raimund Hook <email address hidden>
Date: Mon Apr 20 12:20:04 2020 +0100

    Update Advanced Config guide to clarify paths

    This update clears up an additional path that was mentioned in the
    Advanced Configuration documentation, but not actually picked up in the
    playbooks.

    This specifically affects Service Configuration overrides. The docs have
    been cleaned up to reflect the way the playbooks pick up the override
    files.

    Change-Id: Id15fe139af6462217c2ac26d7d21c5eac5368e12
    Closes-Bug: 1873782
    Signed-off-by: Raimund Hook <email address hidden>
    (cherry picked from commit 08682243ed534366ff7ef52a538e14ad04d01f1c)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.