kolla-ansible

service_mapped_to_host filter always matches if group exists

Bug #1868285 reported by Mark Goddard
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla-ansible
Fix Released
Medium
Mark Goddard
kolla-ansible 10.0.0 "ussuri"
Train
Fix Released
Medium
Radosław Piliszek
Ussuri
Fix Released
Medium
Mark Goddard
kolla-ansible 10.0.0 "ussuri"

Bug Description

The service_mapped_to_host filter is used to check if a service is mapped to a host, based on the group for the service or its host_in_groups attribute if one exists. We check if the service's group is in the 'groups' list. However, to get the list of groups to which a host belongs, we should use the 'group_names' list.

This filter is currently only used in neutron IPv6 module loading, so the effects are minimal.

See original description
Mark Goddard (mgoddard)
description: updated
Changed in kolla-ansible:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (master)

Fix proposed to branch: master
Review: https://review.opendev.org/714177

Changed in kolla-ansible:
assignee: nobody → Mark Goddard (mgoddard)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (master)

Reviewed: https://review.opendev.org/714177
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=35966c9186d868948a037bae7c58ac6e6279a4f0
Submitter: Zuul
Branch: master

commit 35966c9186d868948a037bae7c58ac6e6279a4f0
Author: Mark Goddard <email address hidden>
Date: Fri Mar 20 17:03:14 2020 +0000

    Fix service_mapped_to_host filter

    The service_mapped_to_host filter is used to check if a service is
    mapped to a host, based on the group for the service or its
    host_in_groups attribute if one exists. We check if the service's group
    is in the 'groups' list. However, to get the list of groups to which a
    host belongs, we should use the 'group_names' list.

    This filter is currently only used in neutron IPv6 module loading, so
    the effects are minimal.

    Change-Id: I37409ca8d273b0426df0a648db222dc5432e738a
    Closes-Bug: #1868285

Changed in kolla-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/714250

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/train)

Reviewed: https://review.opendev.org/714250
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=8f566781051ee7b227e018d51296f24589384786
Submitter: Zuul
Branch: stable/train

commit 8f566781051ee7b227e018d51296f24589384786
Author: Mark Goddard <email address hidden>
Date: Fri Mar 20 17:03:14 2020 +0000

    Fix service_mapped_to_host filter

    The service_mapped_to_host filter is used to check if a service is
    mapped to a host, based on the group for the service or its
    host_in_groups attribute if one exists. We check if the service's group
    is in the 'groups' list. However, to get the list of groups to which a
    host belongs, we should use the 'group_names' list.

    This filter is currently only used in neutron IPv6 module loading, so
    the effects are minimal.

    Change-Id: I37409ca8d273b0426df0a648db222dc5432e738a
    Closes-Bug: #1868285
    (cherry picked from commit 35966c9186d868948a037bae7c58ac6e6279a4f0)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.