When internal vip address is undefined, error message is about "kolla_internal_address"

[Radosław Piliszek]

For some reason k-a default to kolla_internal_address for kolla_internal_vip_address.
Since the former is not documented/defined at all, it would be better to undefine kolla_internal_address to avoid confusion and get proper errors (documentation backed).

[Radosław Piliszek (yoctozepto)]

Good one, thanks, Mark.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/720338

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/720338
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=b4603d927152f95848e56f6cf3ed4acd88baa377
Submitter: Zuul
Branch: master

commit b4603d927152f95848e56f6cf3ed4acd88baa377
Author: chenxing <email address hidden>
Date: Thu Apr 16 11:59:53 2020 +0800

    Deprecate kolla_internal_address variable

    The "kolla_internal_address" variable is not documented or defined
    anywhere. When "kolla_internal_vip_address" is undefined, the error
    message is about "kolla_internal_address", which will confuse operators.

    This change deprecates "kolla_internal_address", and adds a default
    value for "kolla_internal_vip_address" when "kolla_internal_address" is
    undefined.

    Change-Id: I09694b38420ea67896bb8cf4ffd7ce6f131af10e
    Closes-Bug: #1864206

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/749899

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/749900

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/749901

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/749902

[OpenStack Infra (hudson-openstack)]

Change abandoned by Radosław Piliszek (<email address hidden>) on branch: stable/rocky
Review: https://review.opendev.org/749902
Reason: let's not do this for https://review.opendev.org/749910

[OpenStack Infra (hudson-openstack)]

Change abandoned by Radosław Piliszek (<email address hidden>) on branch: stable/stein
Review: https://review.opendev.org/749901
Reason: let's not do this for https://review.opendev.org/749910

[OpenStack Infra (hudson-openstack)]

Change abandoned by Radosław Piliszek (<email address hidden>) on branch: stable/train
Review: https://review.opendev.org/749900
Reason: let's not do this for https://review.opendev.org/749910

[OpenStack Infra (hudson-openstack)]

Change abandoned by Radosław Piliszek (<email address hidden>) on branch: stable/ussuri
Review: https://review.opendev.org/749899
Reason: let's not do this for https://review.opendev.org/749910

[OpenStack Infra (hudson-openstack)]

Change abandoned by Radosław Piliszek (<email address hidden>) on branch: stable/rocky
Review: https://review.opendev.org/749902
Reason: we don't have it bugged in rocky

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/749899
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=0e9287fe083dded241c5d35147996737afceae59
Submitter: Zuul
Branch: stable/ussuri

commit 0e9287fe083dded241c5d35147996737afceae59
Author: chenxing <email address hidden>
Date: Thu Apr 16 11:59:53 2020 +0800

    Add default value for kolla_internal_address variable

    The "kolla_internal_address" variable is not documented or defined
    anywhere. When "kolla_internal_vip_address" is undefined, the error
    message is about "kolla_internal_address", which will confuse operators.

    This change adds a default value for "kolla_internal_vip_address" when
    "kolla_internal_address" is undefined.

    Change-Id: I09694b38420ea67896bb8cf4ffd7ce6f131af10e
    Closes-Bug: #1864206
    (cherry picked from commit b4603d927152f95848e56f6cf3ed4acd88baa377)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/749901
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=c9845c0e63f3978b3ac2825997bba03faae09b2c
Submitter: Zuul
Branch: stable/stein

commit c9845c0e63f3978b3ac2825997bba03faae09b2c
Author: chenxing <email address hidden>
Date: Thu Apr 16 11:59:53 2020 +0800

    Add default value for kolla_internal_address variable

    The "kolla_internal_address" variable is not documented or defined
    anywhere. When "kolla_internal_vip_address" is undefined, the error
    message is about "kolla_internal_address", which will confuse operators.

    This change adds a default value for "kolla_internal_vip_address" when
    "kolla_internal_address" is undefined.

    Change-Id: I09694b38420ea67896bb8cf4ffd7ce6f131af10e
    Closes-Bug: #1864206
    (cherry picked from commit b4603d927152f95848e56f6cf3ed4acd88baa377)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/749900
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=c5e8162ff84478ec81e49b0f54a6821c31c432c6
Submitter: Zuul
Branch: stable/train

commit c5e8162ff84478ec81e49b0f54a6821c31c432c6
Author: chenxing <email address hidden>
Date: Thu Apr 16 11:59:53 2020 +0800

    Add default value for kolla_internal_address variable

    The "kolla_internal_address" variable is not documented or defined
    anywhere. When "kolla_internal_vip_address" is undefined, the error
    message is about "kolla_internal_address", which will confuse operators.

    This change adds a default value for "kolla_internal_vip_address" when
    "kolla_internal_address" is undefined.

    Change-Id: I09694b38420ea67896bb8cf4ffd7ce6f131af10e
    Closes-Bug: #1864206
    (cherry picked from commit b4603d927152f95848e56f6cf3ed4acd88baa377)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla-ansible 8.3.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla-ansible 10.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla-ansible 9.3.0 release.