Kibana deployment fails due to invalid value for elasticsearch.ssl.certificateAuthorities

[Mark Goddard]

When deploying Kibana with the default configuration of openstack_cacert being unset, it fails due to an invalid configuration. The error message is both unfriendly and useless:

"message":"child \"elasticsearch\" fails because [child \"ssl\" fails because [child \"certificateAuthorities\" fails because [single value of \"certificateAuthorities\" fails because [\"certificateAuthorities\" must be a string]]]]"}

This is because we set elasticsearch.ssl.certificateAuthorities even when there is no CA cert configured.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/709091

[Radosław Piliszek (yoctozepto)]

You mean "useless" rather than "useful".

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/709091
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=6bae6da36c069387632a12788c8493b336b109de
Submitter: Zuul
Branch: master

commit 6bae6da36c069387632a12788c8493b336b109de
Author: Mark Goddard <email address hidden>
Date: Fri Feb 21 10:14:50 2020 +0000

    Fix kibana deployment with openstack_cacert unset

    When deploying Kibana with the default configuration of openstack_cacert
    being unset, it fails due to an invalid configuration. The error message
    is both unfriendly and useful:

    "message":"child \"elasticsearch\" fails because [child \"ssl\" fails
    because [child \"certificateAuthorities\" fails because [single value of
    \"certificateAuthorities\" fails because [\"certificateAuthorities\"
    must be a string]]]]"}

    This is because we set elasticsearch.ssl.certificateAuthorities even
    when there is no CA cert configured.

    This change fixes the issue by only setting
    elasticsearch.ssl.certificateAuthorities when a CA cert is configured.

    Change-Id: I5954751451b7c931e8a9d79c713a2798522d8b81
    Closes-Bug: #1864180