Kibana, elasticsearch and monasca roles failing with invalid JSON body

[Mark Goddard]

The kibana, elasticsearch and monasca roles all use the uri module to perform Elasticsearch configuration tasks via its API. The body of the request should be JSON formatted, but these tasks now fail because it is not. This was probably caused by the recent change to execute these tasks in the kolla_toolbox container, but may also be caused by an Ansible version bump (or something else).

The following error is seen:

TASK [monasca : Create default control plane organisation if it doesn't exist]

invalid character '\\'' looking for beginning of object key string

The 'JSON' body in this case was:

{'name': 'monasca_control_plane@default'}

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/709090

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/709090
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=5db9eab04223dd3e974e39490a84c506805b8644
Submitter: Zuul
Branch: master

commit 5db9eab04223dd3e974e39490a84c506805b8644
Author: Mark Goddard <email address hidden>
Date: Fri Feb 21 10:08:10 2020 +0000

    Fix invalid JSON body in Elasticsearch API requests

    The kibana, elasticsearch and monasca roles all use the uri module to
    perform Elasticsearch configuration tasks via its API. The body of the
    request should be JSON formatted, but these tasks now fail because it is
    not.

    The following error is seen:

    TASK [monasca : Create default control plane organisation if it doesn't
    exist]

    invalid character '\\'' looking for beginning of object key string

    The 'JSON' body in this case was:

    {'name': 'monasca_control_plane@default'}

    This was probably caused by the recent change to execute these tasks in
    the kolla_toolbox container, but may also be caused by an Ansible
    version bump (or something else).

    This change fixes the issue by ensuring that the body is JSON-encoded in
    all cases.

    Change-Id: I7acc097381dd9a4af4e014525c1c88213abbde93
    Closes-Bug: #1864177