kolla-ansible genconfig performs host configuration

Bug #1860161 reported by Mark Goddard
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla-ansible
Fix Released
Medium
Mark Goddard
Stein
Fix Released
Medium
Unassigned
Train
Fix Released
Medium
Unassigned
Ussuri
Fix Released
Medium
Mark Goddard

Bug Description

Currently there are a few services that perform host configuration tasks. This is done in config.yml. This means that these changes are performed during 'kolla-ansible genconfig', when we might expect not to be making any changes to the remote system.

Mark Goddard (mgoddard)
Changed in kolla-ansible:
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (master)

Fix proposed to branch: master
Review: https://review.opendev.org/703127

Changed in kolla-ansible:
assignee: nobody → Mark Goddard (mgoddard)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (master)

Reviewed: https://review.opendev.org/703127
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=fdea19a305c0926f4be4c0c5f29e57bdb5a9ee85
Submitter: Zuul
Branch: master

commit fdea19a305c0926f4be4c0c5f29e57bdb5a9ee85
Author: Mark Goddard <email address hidden>
Date: Fri Jan 17 17:00:21 2020 +0000

    Separate per-service host configuration tasks

    Currently there are a few services that perform host configuration
    tasks. This is done in config.yml. This means that these changes are
    performed during 'kolla-ansible genconfig', when we might expect not to
    be making any changes to the remote system.

    This change separates out these host configuration tasks into a
    config-host.yml file, which is included directly from deploy.yml.

    One change in behaviour is that this prevents these tasks from running
    during an upgrade or genconfig. This is probably what we want, but we
    should be careful when any of these host configuration tasks are
    changed, to ensure they are applied during an upgrade if necessary.

    Change-Id: I001defc75d1f1e6caa9b1e11246abc6ce17c775b
    Closes-Bug: #1860161

Changed in kolla-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to kolla-ansible (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/718507

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to kolla-ansible (master)

Reviewed: https://review.opendev.org/718507
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=1d70f509e30688826304e57775eabcd7b1e9afd2
Submitter: Zuul
Branch: master

commit 1d70f509e30688826304e57775eabcd7b1e9afd2
Author: Mark Goddard <email address hidden>
Date: Wed Apr 8 17:03:04 2020 +0100

    Perform host configuration during upgrade

    This is a follow up to I001defc75d1f1e6caa9b1e11246abc6ce17c775b. To
    maintain previous behaviour, and ensure we catch any host configuration
    changes, we should perform host configuration during upgrade.

    Change-Id: I79fcbf1efb02b7187406d3c3fccea6f200bcea69
    Related-Bug: #1860161

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/723337

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/723339

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/train)

Reviewed: https://review.opendev.org/723337
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=093c1f0a4605e4fc27b7070505c79680c2fcc538
Submitter: Zuul
Branch: stable/train

commit 093c1f0a4605e4fc27b7070505c79680c2fcc538
Author: Mark Goddard <email address hidden>
Date: Fri Jan 17 17:00:21 2020 +0000

    Separate per-service host configuration tasks

    Currently there are a few services that perform host configuration
    tasks. This is done in config.yml. This means that these changes are
    performed during 'kolla-ansible genconfig', when we might expect not to
    be making any changes to the remote system.

    This change separates out these host configuration tasks into a
    config-host.yml file, which is included directly from deploy.yml.

    One change in behaviour is that this prevents these tasks from running
    during genconfig.

    This commit also includes a follow up to the original commit,
    I79fcbf1efb02b7187406d3c3fccea6f200bcea69: Perform host configuration
    during upgrade

    To maintain previous behaviour, and ensure we catch any host
    configuration changes, we should perform host configuration during
    upgrade.

    Change-Id: I001defc75d1f1e6caa9b1e11246abc6ce17c775b
    Closes-Bug: #1860161
    (cherry picked from commit fdea19a305c0926f4be4c0c5f29e57bdb5a9ee85)
    (cherry picked from commit 1d70f509e30688826304e57775eabcd7b1e9afd2)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/stein)

Reviewed: https://review.opendev.org/723339
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=ae6cef7f0092ac4088207aebbac739353dc3f9b1
Submitter: Zuul
Branch: stable/stein

commit ae6cef7f0092ac4088207aebbac739353dc3f9b1
Author: Mark Goddard <email address hidden>
Date: Fri Jan 17 17:00:21 2020 +0000

    Separate per-service host configuration tasks

    Currently there are a few services that perform host configuration
    tasks. This is done in config.yml. This means that these changes are
    performed during 'kolla-ansible genconfig', when we might expect not to
    be making any changes to the remote system.

    This change separates out these host configuration tasks into a
    config-host.yml file, which is included directly from deploy.yml.

    One change in behaviour is that this prevents these tasks from running
    during genconfig.

    This commit also includes a follow up to the original commit,
    I79fcbf1efb02b7187406d3c3fccea6f200bcea69: Perform host configuration
    during upgrade

    To maintain previous behaviour, and ensure we catch any host
    configuration changes, we should perform host configuration during
    upgrade.

    Change-Id: I001defc75d1f1e6caa9b1e11246abc6ce17c775b
    Closes-Bug: #1860161
    (cherry picked from commit fdea19a305c0926f4be4c0c5f29e57bdb5a9ee85)
    (cherry picked from commit 1d70f509e30688826304e57775eabcd7b1e9afd2)

tags: added: in-stable-stein
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.