Change in globals.yml is not passed to environment

[Viktor Michalek]

The change of variable value neutron_legacy_iptables in globals.yml is not passed to corresponding environment variable KOLLA_LEGACY_IPTABLES during reconfigure run, i.e.

When deployed with globals.yml setting:
neutron_legacy_iptables: "no"
There remains value FALSE in variable KOLLA_LEGACY_IPTABLES despite the change of neutron_legacy_iptables to "yes" and then then finished `kolla-ansible reconfigure`.

[Mark Goddard (mgoddard)]

Viktor, here is the relevant code: https://opendev.org/openstack/kolla-ansible/src/branch/master/ansible/library/kolla_docker.py#L455

[Radosław Piliszek (yoctozepto)]

Mark probably meant this part
https://opendev.org/openstack/kolla-ansible/src/commit/6446eb76acdf0397e80258db287cf51c395fd8a8/ansible/library/kolla_docker.py#L455-L467

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/746965

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/746965
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=ed2a2704d13fa70a8dc783960d05f5469639425c
Submitter: Zuul
Branch: master

commit ed2a2704d13fa70a8dc783960d05f5469639425c
Author: Michal Arbet <email address hidden>
Date: Wed Aug 19 17:23:18 2020 +0200

    Fix kolla-ansible not reflect environment changed

    Neutron's containers should use ENV from kolla_docker module's
    environment parameter (defined in roles/neutron/defaults/main.yml)
    after reconfigure, not only when deploying.

    Currently this is working only for deploy, not for reconfigure.

    How to test it ?
    - Deploy neutron with "neutron_legacy_iptables" set to yes/no.
    - Change value of "neutron_legacy_iptables" to opposite value as before.
    - Reconfigure neutron.

    Current result :
     - "KOLLA_LEGACY_IPTABLES" in container's ENV is not changed

    Expected result :
     - "KOLLA_LEGACY_IPTABLES:" in container's ENV should be changed

    This patch is fixing this behaviour by adding missing
    environment parameter to neutron's "Check neutron containers" task.

    Change-Id: Ibfbe2d4f49261fa766acbb6ff45da9994118bda8
    Closes-Bug: #1853776

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/747461

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/747462

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/747461
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=75f8ce358c648248941c1fbabc155e887f637e1a
Submitter: Zuul
Branch: stable/ussuri

commit 75f8ce358c648248941c1fbabc155e887f637e1a
Author: Michal Arbet <email address hidden>
Date: Wed Aug 19 17:23:18 2020 +0200

    Fix kolla-ansible not reflect environment changed

    Neutron's containers should use ENV from kolla_docker module's
    environment parameter (defined in roles/neutron/defaults/main.yml)
    after reconfigure, not only when deploying.

    Currently this is working only for deploy, not for reconfigure.

    How to test it ?
    - Deploy neutron with "neutron_legacy_iptables" set to yes/no.
    - Change value of "neutron_legacy_iptables" to opposite value as before.
    - Reconfigure neutron.

    Current result :
     - "KOLLA_LEGACY_IPTABLES" in container's ENV is not changed

    Expected result :
     - "KOLLA_LEGACY_IPTABLES:" in container's ENV should be changed

    This patch is fixing this behaviour by adding missing
    environment parameter to neutron's "Check neutron containers" task.

    Change-Id: Ibfbe2d4f49261fa766acbb6ff45da9994118bda8
    Closes-Bug: #1853776
    (cherry picked from commit ed2a2704d13fa70a8dc783960d05f5469639425c)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/747462
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=06c6e14e5e66f09615631ddf56e47101a6819ca8
Submitter: Zuul
Branch: stable/train

commit 06c6e14e5e66f09615631ddf56e47101a6819ca8
Author: Michal Arbet <email address hidden>
Date: Wed Aug 19 17:23:18 2020 +0200

    Fix kolla-ansible not reflect environment changed

    Neutron's containers should use ENV from kolla_docker module's
    environment parameter (defined in roles/neutron/defaults/main.yml)
    after reconfigure, not only when deploying.

    Currently this is working only for deploy, not for reconfigure.

    How to test it ?
    - Deploy neutron with "neutron_legacy_iptables" set to yes/no.
    - Change value of "neutron_legacy_iptables" to opposite value as before.
    - Reconfigure neutron.

    Current result :
     - "KOLLA_LEGACY_IPTABLES" in container's ENV is not changed

    Expected result :
     - "KOLLA_LEGACY_IPTABLES:" in container's ENV should be changed

    This patch is fixing this behaviour by adding missing
    environment parameter to neutron's "Check neutron containers" task.

    Change-Id: Ibfbe2d4f49261fa766acbb6ff45da9994118bda8
    Closes-Bug: #1853776
    (cherry picked from commit ed2a2704d13fa70a8dc783960d05f5469639425c)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla-ansible 10.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla-ansible 9.3.0 release.