rsyncd configuration is too opiniated on the number of max connections

Bug #1852095 reported by Alexis Deberg
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla-ansible
In Progress
Undecided
Unassigned

Bug Description

Right now the rsyncd configuration is too opiniated on the number of max connections, using small hardcoded values, e.g 8 for the "object" section.

I believe this should be parametrized to allow customization.

The related template is https://opendev.org/openstack/kolla-ansible/src/branch/master/ansible/roles/swift/templates/rsyncd.conf.j2

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (master)

Fix proposed to branch: master
Review: https://review.opendev.org/693728

Changed in kolla-ansible:
assignee: nobody → Alexis Deberg (adeberg)
status: New → In Progress
Revision history for this message
Alexis Deberg (adeberg) wrote :

I unfortunately don't have time to work on that these days, unassigning myself, open for grab

Changed in kolla-ansible:
assignee: Alexis Deberg (adeberg) → nobody
Revision history for this message
Radosław Piliszek (yoctozepto) wrote :

It really needs just a docs update if one is brave enough to undertake it. :-)

Revision history for this message
Alexis Deberg (adeberg) wrote :

Well, I don't agree with that, rsyncd.conf should be customizable. merge_configs should be leveraged (see my initial proposed fix comments).

Or do you say docs to point out that it's opiniated ?

Revision history for this message
Radosław Piliszek (yoctozepto) wrote :

Ah, right. I thought it was made customizable already. Sorry. It should be customizable.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.