openstack_release 'auto' makes invalid tagging for image

Bug #1843518 reported by Yang Youseok
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla-ansible
Fix Released
Medium
Chason Chan
Train
Fix Released
Medium
Chason Chan

Bug Description

I'm afraid that it was users fault who does not know the variable's meaning though,
when I use 'openstack_release = auto' which is default docker was trying to find image with tagging which is same as 'kolla ansible itself'.

It means if I use kolla-ansible which have 8.1.0 tagging, any docker images could not found since kolla docker image does not have 8.1.0 tag.

Pbr versionInfo use pip version rather than git branch tagging, currently it never found valid image.

Thanks

Yang Youseok (ileixe)
description: updated
Revision history for this message
Mark Goddard (mgoddard) wrote :

This is by design, although I agree it is not very intuitive. We should use the release name as the default tag, since this is what we publish to Dockerhub.

Changed in kolla-ansible:
status: New → Triaged
importance: Undecided → Medium
Chason Chan (chen-xing)
Changed in kolla-ansible:
assignee: nobody → Chason Chan (chen-xing)
Revision history for this message
Chason Chan (chen-xing) wrote :

@Mark Hi, any idea to get the branch name just like using "pbr" to get tag? should we store the git branch name to the file?

Revision history for this message
Mark Goddard (mgoddard) wrote :

@Chason, I suggest we just keep it static for now, and put it on the list of things we need to change when we cut a release branch. So in master we just set openstack_release to master.

Revision history for this message
Chason Chan (chen-xing) wrote :

OK, I will commit a patch soon, thanks! :)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (master)

Fix proposed to branch: master
Review: https://review.opendev.org/681633

Changed in kolla-ansible:
status: Triaged → In Progress
Changed in kolla-ansible:
assignee: Chason Chan (chen-xing) → Mark Goddard (mgoddard)
Mark Goddard (mgoddard)
Changed in kolla-ansible:
assignee: Mark Goddard (mgoddard) → Chason Chan (chen-xing)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (master)

Reviewed: https://review.opendev.org/681633
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=4eceb48d2dd2496a9becd878cd55e3bdf67415b2
Submitter: Zuul
Branch: master

commit 4eceb48d2dd2496a9becd878cd55e3bdf67415b2
Author: chenxing <email address hidden>
Date: Thu Sep 12 09:25:05 2019 +0800

    Update "openstack_release" variable to static brach name

    Since we use the release name as the default tag to publish images
    to Dockerhub, we should use this by default.

    This change also removes support for the magic value "auto".

    Change-Id: I5610cc7729e9311709147ba5532199a033dfd156
    Closes-Bug: #1843518

Changed in kolla-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 9.0.0.0rc1

This issue was fixed in the openstack/kolla-ansible 9.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.