migration_interface must exist for non-compute controllers

[Radosław Piliszek]

migration_interface, unused for non-libvirt-compute controller, must exist there because templating nova.conf fails otherwise (cannot find the address).

This is not checked by prechecks because it is erroneous.

The workaround is to set the migration_interface to any existing interface for such nodes as it will not be used anyway.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/669631

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/669631
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=b166d2550e2672e2a55554474438e47f96191e82
Submitter: Zuul
Branch: master

commit b166d2550e2672e2a55554474438e47f96191e82
Author: Radosław Piliszek <email address hidden>
Date: Mon Jul 8 12:31:42 2019 +0200

    Do not require valid migration_interface for controllers

    Controllers lacking compute should not be required to provide
    valid migration_interface as it is not used there (and prechecks
    do not check that either).

    Inclusion of libvirt conf section is now conditional on service type.
    libvirt conf section has been moved to separate included file to
    avoid evaluation of the undefined variable (conditional block did not
    prevent it and using 'default' filter may hide future issues).
    See https://github.com/ansible/ansible/issues/58835
    Additionally this fixes the improper nesting of 'if' blocks for libvirt.

    Change-Id: I77af534fbe824cfbe95782ab97838b358c17b928
    Closes-Bug: #1835713
    Signed-off-by: Radosław Piliszek <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/671126

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/671126
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=c28e02e20eff2bdb302cb0adaf9c120cc995c134
Submitter: Zuul
Branch: stable/stein

commit c28e02e20eff2bdb302cb0adaf9c120cc995c134
Author: Radosław Piliszek <email address hidden>
Date: Mon Jul 8 12:31:42 2019 +0200

    Do not require valid migration_interface for controllers

    Controllers lacking compute should not be required to provide
    valid migration_interface as it is not used there (and prechecks
    do not check that either).

    Inclusion of libvirt conf section is now conditional on service type.
    libvirt conf section has been moved to separate included file to
    avoid evaluation of the undefined variable (conditional block did not
    prevent it and using 'default' filter may hide future issues).
    See https://github.com/ansible/ansible/issues/58835
    Additionally this fixes the improper nesting of 'if' blocks for libvirt.

    Change-Id: I77af534fbe824cfbe95782ab97838b358c17b928
    Closes-Bug: #1835713
    Depends-On: https://review.opendev.org/671127
    Signed-off-by: Radosław Piliszek <email address hidden>
    (cherry picked from commit b166d2550e2672e2a55554474438e47f96191e82)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla-ansible 8.0.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla-ansible 9.0.0.0rc1 release candidate.