glance reconfigure fails when using external ceph

Bug #1826511 reported by Krzysztof Klimonda
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
kolla-ansible
Fix Released
Medium
Unassigned
Rocky
Fix Released
Medium
Unassigned
Stein
Fix Released
Medium
Unassigned
Train
Fix Released
Medium
Unassigned

Bug Description

kolla-ansible version: current stable/stein checkout

When running deploy or reconfigure action on a cluster with external ceph configured[1], handler "Restart glance-api container" fails due to `glance_upgrading` variable being undefined:

```
RUNNING HANDLER [glance : Restart glance-api container] ********************************************************************************************************************************************************************************************************************************************************************************************************************
fatal: [control03.region2.wekeo-dev.cloudferro.com]: FAILED! => {"msg": "The conditional check 'config_json.changed | bool or glance_cache_conf.changed | bool or glance_conf.changed | bool or glance_swift_conf.changed | bool or policy_overwriting.changed | bool or glance_api_container.changed | bool or glance_upgrading | bool or ( glance_api_ceph_files is defined and glance_api_ceph_files.changed | bool )' failed. The error was: error while evaluating conditional (config_json.changed | bool or glance_cache_conf.changed | bool or glance_conf.changed | bool or glance_swift_conf.changed | bool or policy_overwriting.changed | bool or glance_api_container.changed | bool or glance_upgrading | bool or ( glance_api_ceph_files is defined and glance_api_ceph_files.changed | bool )): 'glance_upgrading' is undefined\n\nThe error appears to have been in '/home/kklimonda/repos/kolla-ansible/ansible/roles/glance/handlers/main.yml': line 2, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n---\n- name: Restart glance-api container\n ^ here\n"}
fatal: [control02.region2.wekeo-dev.cloudferro.com]: FAILED! => {"msg": "The conditional check 'config_json.changed | bool or glance_cache_conf.changed | bool or glance_conf.changed | bool or glance_swift_conf.changed | bool or policy_overwriting.changed | bool or glance_api_container.changed | bool or glance_upgrading | bool or ( glance_api_ceph_files is defined and glance_api_ceph_files.changed | bool )' failed. The error was: error while evaluating conditional (config_json.changed | bool or glance_cache_conf.changed | bool or glance_conf.changed | bool or glance_swift_conf.changed | bool or policy_overwriting.changed | bool or glance_api_container.changed | bool or glance_upgrading | bool or ( glance_api_ceph_files is defined and glance_api_ceph_files.changed | bool )): 'glance_upgrading' is undefined\n\nThe error appears to have been in '/home/kklimonda/repos/kolla-ansible/ansible/roles/glance/handlers/main.yml': line 2, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n---\n- name: Restart glance-api container\n ^ here\n"}
fatal: [control01.region2.wekeo-dev.cloudferro.com]: FAILED! => {"msg": "The conditional check 'config_json.changed | bool or glance_cache_conf.changed | bool or glance_conf.changed | bool or glance_swift_conf.changed | bool or policy_overwriting.changed | bool or glance_api_container.changed | bool or glance_upgrading | bool or ( glance_api_ceph_files is defined and glance_api_ceph_files.changed | bool )' failed. The error was: error while evaluating conditional (config_json.changed | bool or glance_cache_conf.changed | bool or glance_conf.changed | bool or glance_swift_conf.changed | bool or policy_overwriting.changed | bool or glance_api_container.changed | bool or glance_upgrading | bool or ( glance_api_ceph_files is defined and glance_api_ceph_files.changed | bool )): 'glance_upgrading' is undefined\n\nThe error appears to have been in '/home/kklimonda/repos/kolla-ansible/ansible/roles/glance/handlers/main.yml': line 2, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n---\n- name: Restart glance-api container\n ^ here\n"}
```

[1] This could also be a problem with deployments with integrated ceph, the variable is defined only during rolling upgrades it seems.

Revision history for this message
Mark Goddard (mgoddard) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (master)

Reviewed: https://review.opendev.org/655836
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=f5b52608663bea5bbe1d58eff1a7bdfd21568173
Submitter: Zuul
Branch: master

commit f5b52608663bea5bbe1d58eff1a7bdfd21568173
Author: Krzysztof Klimonda <email address hidden>
Date: Fri Apr 26 06:54:57 2019 +0000

    Check if glance_upgrading is defined before using it

    glance_upgrading variable is defined only during rolling upgrades, but
    its value is checked on every call to "Restart glance-api container" handler.

    Closes-Bug: #1826511
    Change-Id: Idc95306c50a09666ac0a12e975307a42aef9e352

Changed in kolla-ansible:
status: New → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/656264

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/656266

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/stein)

Reviewed: https://review.opendev.org/656264
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=d5f51d840d008a32f69510a99e9bded84760eebc
Submitter: Zuul
Branch: stable/stein

commit d5f51d840d008a32f69510a99e9bded84760eebc
Author: Krzysztof Klimonda <email address hidden>
Date: Fri Apr 26 06:54:57 2019 +0000

    Check if glance_upgrading is defined before using it

    glance_upgrading variable is defined only during rolling upgrades, but
    its value is checked on every call to "Restart glance-api container" handler.

    Closes-Bug: #1826511
    Change-Id: Idc95306c50a09666ac0a12e975307a42aef9e352
    (cherry picked from commit f5b52608663bea5bbe1d58eff1a7bdfd21568173)

tags: added: in-stable-stein
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/rocky)

Reviewed: https://review.opendev.org/656266
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=1d86b9a0b28c1c2bd5dba4d6b05fd80087b5c500
Submitter: Zuul
Branch: stable/rocky

commit 1d86b9a0b28c1c2bd5dba4d6b05fd80087b5c500
Author: Krzysztof Klimonda <email address hidden>
Date: Fri Apr 26 06:54:57 2019 +0000

    Check if glance_upgrading is defined before using it

    glance_upgrading variable is defined only during rolling upgrades, but
    its value is checked on every call to "Restart glance-api container" handler.

    Closes-Bug: #1826511
    Change-Id: Idc95306c50a09666ac0a12e975307a42aef9e352
    (cherry picked from commit f5b52608663bea5bbe1d58eff1a7bdfd21568173)

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 7.1.1

This issue was fixed in the openstack/kolla-ansible 7.1.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 8.0.0.0rc2

This issue was fixed in the openstack/kolla-ansible 8.0.0.0rc2 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 9.0.0.0rc1

This issue was fixed in the openstack/kolla-ansible 9.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.