kolla-ansible version: current stable/stein checkout
When running deploy or reconfigure action on a cluster with external ceph configured[1], handler "Restart glance-api container" fails due to `glance_upgrading` variable being undefined:
```
RUNNING HANDLER [glance : Restart glance-api container] ********************************************************************************************************************************************************************************************************************************************************************************************************************
fatal: [control03.region2.wekeo-dev.cloudferro.com]: FAILED! => {"msg": "The conditional check 'config_json.changed | bool or glance_cache_conf.changed | bool or glance_conf.changed | bool or glance_swift_conf.changed | bool or policy_overwriting.changed | bool or glance_api_container.changed | bool or glance_upgrading | bool or ( glance_api_ceph_files is defined and glance_api_ceph_files.changed | bool )' failed. The error was: error while evaluating conditional (config_json.changed | bool or glance_cache_conf.changed | bool or glance_conf.changed | bool or glance_swift_conf.changed | bool or policy_overwriting.changed | bool or glance_api_container.changed | bool or glance_upgrading | bool or ( glance_api_ceph_files is defined and glance_api_ceph_files.changed | bool )): 'glance_upgrading' is undefined\n\nThe error appears to have been in '/home/kklimonda/repos/kolla-ansible/ansible/roles/glance/handlers/main.yml': line 2, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n---\n- name: Restart glance-api container\n ^ here\n"}
fatal: [control02.region2.wekeo-dev.cloudferro.com]: FAILED! => {"msg": "The conditional check 'config_json.changed | bool or glance_cache_conf.changed | bool or glance_conf.changed | bool or glance_swift_conf.changed | bool or policy_overwriting.changed | bool or glance_api_container.changed | bool or glance_upgrading | bool or ( glance_api_ceph_files is defined and glance_api_ceph_files.changed | bool )' failed. The error was: error while evaluating conditional (config_json.changed | bool or glance_cache_conf.changed | bool or glance_conf.changed | bool or glance_swift_conf.changed | bool or policy_overwriting.changed | bool or glance_api_container.changed | bool or glance_upgrading | bool or ( glance_api_ceph_files is defined and glance_api_ceph_files.changed | bool )): 'glance_upgrading' is undefined\n\nThe error appears to have been in '/home/kklimonda/repos/kolla-ansible/ansible/roles/glance/handlers/main.yml': line 2, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n---\n- name: Restart glance-api container\n ^ here\n"}
fatal: [control01.region2.wekeo-dev.cloudferro.com]: FAILED! => {"msg": "The conditional check 'config_json.changed | bool or glance_cache_conf.changed | bool or glance_conf.changed | bool or glance_swift_conf.changed | bool or policy_overwriting.changed | bool or glance_api_container.changed | bool or glance_upgrading | bool or ( glance_api_ceph_files is defined and glance_api_ceph_files.changed | bool )' failed. The error was: error while evaluating conditional (config_json.changed | bool or glance_cache_conf.changed | bool or glance_conf.changed | bool or glance_swift_conf.changed | bool or policy_overwriting.changed | bool or glance_api_container.changed | bool or glance_upgrading | bool or ( glance_api_ceph_files is defined and glance_api_ceph_files.changed | bool )): 'glance_upgrading' is undefined\n\nThe error appears to have been in '/home/kklimonda/repos/kolla-ansible/ansible/roles/glance/handlers/main.yml': line 2, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n---\n- name: Restart glance-api container\n ^ here\n"}
```
[1] This could also be a problem with deployments with integrated ceph, the variable is defined only during rolling upgrades it seems.
Fix proposed here: https:/ /review. opendev. org/#/c/ 655836