Prometheus server isn't restarted when config changes

Bug #1820241 reported by Doug Szumski
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla-ansible
Fix Released
Undecided
Doug Szumski

Bug Description

If the Prometheus server config is updated, for example due to adding a new service, Prometheus server isn't restarted.

Example:

TASK [prometheus : Copying over prometheus config file] *************************************************************
<snip>
changed: [mon0001] => (item=/home/doug/venvs/kolla-ansible/share/kolla-ansible/ansible/roles/prometheus/templates/prometheus.yml.j2)

<snip>
RUNNING HANDLER [prometheus : Restart prometheus-server container] ***************************************************
skipping: [mon0001]

Revision history for this message
Doug Szumski (dszumski) wrote :

This affects the Rocky branch and is fixed by this commit on master:

I882759c3774f43640631c1058f8a9cb24e7a60d2

Changed in kolla-ansible:
assignee: nobody → Doug Szumski (dszumski)
Revision history for this message
Doug Szumski (dszumski) wrote :

The commit on master which fixes the issue adds additional functionality over the minimal fix for this issue:

https://bugs.launchpad.net/kolla-ansible/+bug/1776529

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/643559

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/rocky)

Reviewed: https://review.openstack.org/643559
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=47883649e03973d56d24d3e97c158494a7edf541
Submitter: Zuul
Branch: stable/rocky

commit 47883649e03973d56d24d3e97c158494a7edf541
Author: Doug Szumski <email address hidden>
Date: Fri Mar 15 10:03:47 2019 +0000

    Fix Prometheus Server/Alertmanager config update

    The Alertmanger config task conflicts with the Prometheus Server task
    by overwriting the variable used to determine whether the server
    config was updated. This has been fixed in master, but the commit
    in master combines the fix with a new feature. See #1776529.

    Change-Id: I38409d8a4b94b29ef5d7a4434c53bf0d7da8e443
    Closes-Bug: #1820241

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 7.1.0

This issue was fixed in the openstack/kolla-ansible 7.1.0 release.

Changed in kolla-ansible:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.