Ironic should advertise TFTP server on api_interface

[Mark Goddard]

The ironic TFTP server should be accessed via the internal API network. For ironic inspector, dnsmasq.conf advertises this correctly:

dhcp-option=option:tftp-server,{{ api_interface_address }}
dhcp-option=option:server-ip-address,{{ api_interface_address }}

However, ironic conductor does not set the [pxe] tftp_server variable. This means the TFTP server advertised gets the default value of $my_ip, which is set by https://docs.openstack.org/oslo.utils/latest/reference/netutils.html#oslo_utils.netutils.get_my_ipv4, typically the source IP for the default route.

Kolla Ansible should set [pxe] tftp_server to {{ api_interface_address }}.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/625006

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/625006
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=4d6464669976012a6db976cf908dad6af48d7073
Submitter: Zuul
Branch: master

commit 4d6464669976012a6db976cf908dad6af48d7073
Author: Mark Goddard <email address hidden>
Date: Thu Dec 13 14:07:41 2018 +0000

    Set [pxe] tftp_server in ironic.conf

    The ironic TFTP server should be accessed via the internal API network.
    For ironic inspector, dnsmasq.conf advertises this correctly:

    dhcp-option=option:tftp-server,'api_interface_address'
    dhcp-option=option:server-ip-address,'api_interface_address'

    However, ironic conductor does not set the [pxe] tftp_server variable.
    This means the TFTP server advertised gets the default value of $my_ip,
    which is set by
    https://docs.openstack.org/oslo.utils/latest/reference/netutils.html#oslo_utils.netutils.get_my_ipv4,
    typically the source IP for the default route.

    This change sets [pxe] tftp_server to 'api_interface_address'.

    Change-Id: Ic3e688b3f2b92ad9515322f49cd5f4f29d763e49
    Closes-Bug: #1808347

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla-ansible 8.0.0.0rc1 release candidate.