TLS certificate generation uses wrong path

[Mark Goddard]

When generating TLS certificates via 'kolla-ansible certificates', the path used is incorrect.

The variable {{ node_config_directory }} is used for the configuration directory on the remote hosts, and should not be used for paths on the deploy host (localhost).

The path should reference {{ CONFIG_DIR }}, in line with the directory used for admin-openrc.sh.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/554527
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=9223deeecd5a6c6efa238463962ea8604d4ce103
Submitter: Zuul
Branch: master

commit 9223deeecd5a6c6efa238463962ea8604d4ce103
Author: caoyuan <[e-mail]>
Date: Tue Mar 20 20:31:24 2018 +0800

    Use correct variable for default certificate paths

    The variable {{ node_config_directory }} is used for the configuration
    directory on the remote hosts, and should not be used for paths on the
    deploy host (localhost).

    This changes the default value of the TLS certificate and CA file to
    reference {{ CONFIG_DIR }}, in line with the directory used for
    admin-openrc.sh (as of I0709482ead4b7a67e82796e17f85bde151e71bc0).

    This change also introduces a variable, {{ node_config }}, that
    references {{ CONFIG_DIR | default('/etc/kolla') }}, to remove
    duplication.

    Change-Id: Ibd82ac78630ebfff5824c329d7399e1e900c0ee0
    Closes-Bug: #1804025

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla-ansible 8.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/630683

[OpenStack Infra (hudson-openstack)]

Change abandoned by caoyuan ([e-mail]) on branch: stable/rocky
Review: https://review.opendev.org/630683