Syntax issue in ovs-dpdk's main.yml

Bug #1791686 reported by Erwan Le Bonniec
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla-ansible
Fix Released
Undecided
Chason Chan

Bug Description

kolla-ansible version: 7.0.0
kolla-ansible: stable/rocky

In the File ansible/roles/ovs-dpdk/handlers/main.yml, task "Ensuring ovsdpdk bridges are properly setup named", there is a close parenthesis missing in the "when" condition leading to a failed deployment.
https://github.com/openstack/kolla-ansible/blob/stable/rocky/ansible/roles/ovs-dpdk/handlers/main.yml#L90

The error when deploying is :

RUNNING HANDLER [ovs-dpdk : Ensuring ovsdpdk bridges are properly setup indexed] ***********************************************************************************************
fatal: [proto-nik]: FAILED! => {"msg": "The conditional check '(inventory_hostname in groups['compute'] or (enable_manila | bool and inventory_hostname in groups['manila-share'
]) or inventory_hostname in groups['neutron-dhcp-agent'] or inventory_hostname in groups['neutron-l3-agent'] or inventory_hostname in groups['neutron-metadata-agent']' failed.
The error was: template error while templating string: unexpected '}', expected ')'. String: {% if (inventory_hostname in groups['compute'] or (enable_manila | bool and invento
ry_hostname in groups['manila-share']) or inventory_hostname in groups['neutron-dhcp-agent'] or inventory_hostname in groups['neutron-l3-agent'] or inventory_hostname in groups
['neutron-metadata-agent'] %} True {% else %} False {% endif %}\n\nThe error appears to have been in '/usr/local/share/kolla-ansible/ansible/roles/ovs-dpdk/handlers/main.yml':
line 41, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Ensuring ovsdpdk bridges are prope
rly setup indexed\n ^ here\n"}

To correct this change https://github.com/openstack/kolla-ansible/blob/stable/rocky/ansible/roles/ovs-dpdk/handlers/main.yml#L90
from :
 or inventory_hostname in groups['neutron-metadata-agent']
to :
 or inventory_hostname in groups['neutron-metadata-agent'])

Changed in kolla-ansible:
assignee: nobody → Erwan Le Bonniec (noisynoise)
Changed in kolla-ansible:
assignee: Erwan Le Bonniec (noisynoise) → nobody
Chason Chan (chen-xing)
Changed in kolla-ansible:
status: New → Triaged
assignee: nobody → Chason Chan (chen-xing)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (master)

Fix proposed to branch: master
Review: https://review.openstack.org/601479

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/602029

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (master)

Reviewed: https://review.openstack.org/601479
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=8219542f8972f37840509b59582368131a4ca750
Submitter: Zuul
Branch: master

commit 8219542f8972f37840509b59582368131a4ca750
Author: chenxing <email address hidden>
Date: Tue Sep 11 10:47:03 2018 +0800

    Fix the syntax issues of ovs-dpdk

    backport: rocky

    Change-Id: Id437c26376f80462369db1fb3888db2098278f16
    Closes-Bug: #1791686

Changed in kolla-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/rocky)

Reviewed: https://review.openstack.org/602029
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=e63c6369314871ecb419c0038765d7d91be0f4ad
Submitter: Zuul
Branch: stable/rocky

commit e63c6369314871ecb419c0038765d7d91be0f4ad
Author: chenxing <email address hidden>
Date: Tue Sep 11 10:47:03 2018 +0800

    Fix the syntax issues of ovs-dpdk

    backport: rocky

    Change-Id: Id437c26376f80462369db1fb3888db2098278f16
    Closes-Bug: #1791686

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 7.0.0.0rc2

This issue was fixed in the openstack/kolla-ansible 7.0.0.0rc2 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 8.0.0.0b1

This issue was fixed in the openstack/kolla-ansible 8.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.