merge_yaml not doing deep copy

Bug #1786741 reported by Eduardo Gonzalez
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
kolla-ansible
Fix Released
High
Doug Szumski

Bug Description

Merge_yaml module doesn't do a deep copy of >= first level properties, so it doesn't works for most configurations.

Example config:

global:
  resolve_timeout: 5m
  smtp_require_tls: true
  pagerduty_url: https://events.pagerduty.com/v2/enqueue
route:
  receiver: default-receiver
  group_wait: 10s
  group_interval: 5m
  repeat_interval: 3h
  routes:
    - match:
        severity: 'page'
      receiver: xxx-dc-default-receiver

receivers:
  - name: default-receiver
  - name: xxx-dc-default-receiver
    pagerduty_configs:
      - service_key: xxxx

templates: []

Default template:

global:
  resolve_timeout: 5m
  smtp_require_tls: true
route:
  receiver: default-receiver
  group_wait: 10s
  group_interval: 5m
  repeat_interval: 3h
receivers:
  - name: default-receiver
templates: []

Doug Szumski (dszumski)
Changed in kolla-ansible:
assignee: nobody → Doug Szumski (dszumski)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (master)

Fix proposed to branch: master
Review: https://review.openstack.org/614296

Changed in kolla-ansible:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (master)

Reviewed: https://review.openstack.org/614296
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=badb41a49c4b304bc525ba3fb997ef9288e3a6e9
Submitter: Zuul
Branch: master

commit badb41a49c4b304bc525ba3fb997ef9288e3a6e9
Author: Doug Szumski <email address hidden>
Date: Tue Oct 30 15:38:14 2018 +0000

    Support merging nested yaml config

    Closes-Bug: 1786741
    Change-Id: Ic217f3f8194cdcb5e28045e771a0160c1f12280e

Changed in kolla-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 8.0.0.0b1

This issue was fixed in the openstack/kolla-ansible 8.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.