prometheus-alertmanager: merge_yaml not doing recursive copy of properties

[Jorge Niedbalski]

[Environment]

Kolla-ansible master

[Description]

Change https://review.openstack.org/#/c/571826/4/ansible/roles/prometheus/tasks/config.yml
introduced the usage of merge_yaml for prometheus-alertmanager.yml configuration.

However the merge_yaml module doesn't do a deep copy of >= first level properties, so it doesn't works for most configurations.

Example config:

global:
  resolve_timeout: 5m
  smtp_require_tls: true
  pagerduty_url: https://events.pagerduty.com/v2/enqueue
route:
  receiver: default-receiver
  group_wait: 10s
  group_interval: 5m
  repeat_interval: 3h
  routes:
    - match:
        severity: 'page'
      receiver: xxx-dc-default-receiver

receivers:
  - name: default-receiver
  - name: xxx-dc-default-receiver
    pagerduty_configs:
      - service_key: xxxx

templates: []

Default template:

global:
  resolve_timeout: 5m
  smtp_require_tls: true
route:
  receiver: default-receiver
  group_wait: 10s
  group_interval: 5m
  repeat_interval: 3h
receivers:
  - name: default-receiver
templates: []

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/589966

[Eduardo Gonzalez (egonzalez90)]

Jorge, opened a new bug for the merge_yaml issue so it gets fixed on the module in the future.

https://bugs.launchpad.net/kolla-ansible/+bug/1786741

Regards

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/589966
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=19ec40170f254472f1def88fda14fc93f96d50bd
Submitter: Zuul
Branch: master

commit 19ec40170f254472f1def88fda14fc93f96d50bd
Author: Jorge Niedbalski <email address hidden>
Date: Wed Aug 8 12:30:38 2018 -0400

    [prometheus-alertmanager] use template/first_found instead of merge_yaml.

    Change https://review.openstack.org/#/c/571826/4/
    introduced the usage of merge_yaml for rendering the
    prometheus-alertmanager.yml configuration.

    However the merge_yaml module doesn't do a deep copy of >=
    second level properties, so it doesn't works for
    most configurations.

    Bug: #1786077
    Change-Id: I35297c6e2a3800582fb1fd3782a5d93558562b1d
    Signed-off-by: Jorge Niedbalski <email address hidden>