kolla

tools/pre-commit-check does not work

Bug #1778146 reported by Liping Mao
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla
Fix Released
Undecided
Michal Nasiadka

Bug Description

LIMAO-M-H24G:kolla-ansible limao$ tools/pre-commit-hook
=== starting pre-commit checks ===
Checking the following files:
=== bashate checks ===
=== yaml checks ===
=== json checks ===
tools/pre-commit-hook: line 38: /Users/limao/WorkSpace/Community/kolla-ansible/tools/validate-all-json.sh: No such file or directory
=== dockerfile checks ===
tools/pre-commit-hook: line 42: /Users/limao/WorkSpace/Community/kolla-ansible/tools/validate-all-dockerfiles: No such file or directory

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla (master)

Fix proposed to branch: master
Review: https://review.openstack.org/577635

Changed in kolla:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 7.0.0.0b3

This issue was fixed in the openstack/kolla-ansible 7.0.0.0b3 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on kolla (master)

Change abandoned by zhulingjie (<email address hidden>) on branch: master
Review: https://review.openstack.org/577635

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla (master)

Fix proposed to branch: master
Review: https://review.opendev.org/732495

Changed in kolla:
assignee: nobody → Michal Nasiadka (mnasiadka)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (master)

Reviewed: https://review.opendev.org/732495
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=712b258f2d1870b3f07fb67b043769999edb3ef5
Submitter: Zuul
Branch: master

commit 712b258f2d1870b3f07fb67b043769999edb3ef5
Author: mnasiadka <email address hidden>
Date: Tue Jun 2 08:16:52 2020 +0000

    Fix pre-commit-hook

    Currently pre-commit-hook is failing due to yaml validations using
    unversioned python and using non-existent json validations.

    Change-Id: I67dc11efe667e2cc67ea1a731edc5c4a03ebd1e7
    Closes-Bug: #1778146

Changed in kolla:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/733619

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (stable/ussuri)

Reviewed: https://review.opendev.org/733619
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=e246e80d23a2b0bb118a1cc89d5542935fba0ed7
Submitter: Zuul
Branch: stable/ussuri

commit e246e80d23a2b0bb118a1cc89d5542935fba0ed7
Author: mnasiadka <email address hidden>
Date: Tue Jun 2 08:16:52 2020 +0000

    Fix pre-commit-hook

    Currently pre-commit-hook is failing due to yaml validations using
    unversioned python and using non-existent json validations.

    Change-Id: I67dc11efe667e2cc67ea1a731edc5c4a03ebd1e7
    Closes-Bug: #1778146
    (cherry picked from commit 712b258f2d1870b3f07fb67b043769999edb3ef5)

tags: added: in-stable-ussuri
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.