kolla-ansible

etcd compare_container skip the environment

Bug #1765517 reported by Simon Piette on 2018-04-19

This bug affects 2 people

Affects		Status	Importance	Assigned to	Milestone
	kolla-ansible	Fix Released	Undecided	Simon Piette

Bug Description

kolla-ansible==5.0.2
kolla-ansible==6.0.0

using centos-binary built yesterday

In ansible/roles/etcd/tasks/config.yml, the kolla_docker compare_container action doesn't check environment.

Once a container is created, it won't get recreated if only the environment change.

Provided patch just add the environment attribute to the kolla_docker action.

Tags:

Revision history for this message

Simon Piette (simon.piette) wrote on 2018-04-19:

patch for master branch (queens) Edit (464 bytes, text/plain)

Revision history for this message

Simon Piette (simon.piette) wrote on 2018-04-19:

patch for 5.0.2 (pike) Edit (465 bytes, text/plain)

Simon Piette (simon.piette) on 2018-05-04

Changed in kolla-ansible:
assignee:	nobody → Simon Piette (simon.piette)

Martin Chlumsky (martin-chlumsky) on 2018-05-04

Changed in kolla-ansible:
status:	New → Confirmed

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-05-04: Fix proposed to kolla-ansible (master)

Fix proposed to branch: master
Review: https://review.openstack.org/566383

Changed in kolla-ansible:
status:	Confirmed → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-05-07: Fix merged to kolla-ansible (master)

Reviewed: https://review.openstack.org/566383
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=fdb325aba6ad4a7ec5d0281918571909dbb8fd82
Submitter: Zuul
Branch: master

commit fdb325aba6ad4a7ec5d0281918571909dbb8fd82
Author: Simon Piette <email address hidden>
Date: Fri May 4 14:33:45 2018 -0400

add the environment attribute to etcd deploy

In ansible/roles/etcd/tasks/config.yml, the kolla_docker
compare_container action doesn't check environment.

    Once a container is created, it won't get recreated if only the
    environment change. This commit add the environment attribute to the
    kolla_docker action in etcd role

Change-Id: I8fb71cc945867e06acc67f6d1256bf62f4276206
Closes-Bug: #1765517

Changed in kolla-ansible:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-06-07: Fix included in openstack/kolla-ansible 7.0.0.0b2

This issue was fixed in the openstack/kolla-ansible 7.0.0.0b2 development milestone.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-06-15: Fix proposed to kolla-ansible (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/575713

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-06-15: Fix merged to kolla-ansible (stable/queens)

Reviewed: https://review.openstack.org/575713
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=3460e8b860d73f7e06ce0246d12a0ce2a0e8ea78
Submitter: Zuul
Branch: stable/queens

commit 3460e8b860d73f7e06ce0246d12a0ce2a0e8ea78
Author: Simon Piette <email address hidden>
Date: Fri May 4 14:33:45 2018 -0400

add the environment attribute to etcd deploy

In ansible/roles/etcd/tasks/config.yml, the kolla_docker
compare_container action doesn't check environment.

    Once a container is created, it won't get recreated if only the
    environment change. This commit add the environment attribute to the
    kolla_docker action in etcd role

    Change-Id: I8fb71cc945867e06acc67f6d1256bf62f4276206
    Closes-Bug: #1765517
    (cherry picked from commit fdb325aba6ad4a7ec5d0281918571909dbb8fd82)