Missing common_options when checking keystone containers

[Martin Chlumsky]

- which kolla version you are using
5.0.2

- what's the install type and distro
binary, centos

- where and when the kolla image is built?
Images built on workstation, March 28th 2018

Expected behavior:
The keystone* containers are created with: common_options: "{{ docker_common_options }}" in share/kolla-ansible/ansible/roles/keystone/handlers/main.yml

The keystone* containers are then checked with: common_options: "{{ docker_common_options }}" share/kolla-ansible/ansible/roles/keystone/tasks/config.yml

Actual behavior:
The keystone* containers are created with: common_options: "{{ docker_common_options }}" in share/kolla-ansible/ansible/roles/keystone/handlers/main.yml

The keystone* containers are then checked WITHOUT: common_options: "{{ docker_common_options }}" in share/kolla-ansible/ansible/roles/keystone/tasks/config.yml

This can cause the keystone* containers to get restarted during a reconfigure even though there was no configuration change if you somehow changed docker_common_options.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/557832

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/557832
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=735012c4bb4aaf83aa2eaadefde7b8b0a4674397
Submitter: Zuul
Branch: master

commit 735012c4bb4aaf83aa2eaadefde7b8b0a4674397
Author: Martin Chlumsky <email address hidden>
Date: Thu Mar 29 16:45:31 2018 -0400

    Add common_options to keystone container check

    keystone_* containers are created via the kolla_docker ansible module
    with common_options set to docker_common_options. However, when the
    containers are checked, common_options are not passed to the
    kolla_docker ansible module. This can cause the keystone_* containers
    to be restarted during a reconfigure when there are no changes to
    keystone configuration.

    Add the common_options argument to the kolla_docker ansible module when
    checking the keystone containers and set it to docker_common_options.

    Change-Id: I44aefcf3d71faecaf1ffe384fd5a2f611e584a37
    Closes-Bug: #1759922

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/558106

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/558107

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/558107
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=467ecb1563af74b25706ac044e42ff868bde4495
Submitter: Zuul
Branch: stable/queens

commit 467ecb1563af74b25706ac044e42ff868bde4495
Author: Martin Chlumsky <email address hidden>
Date: Thu Mar 29 16:45:31 2018 -0400

    Add common_options to keystone container check

    keystone_* containers are created via the kolla_docker ansible module
    with common_options set to docker_common_options. However, when the
    containers are checked, common_options are not passed to the
    kolla_docker ansible module. This can cause the keystone_* containers
    to be restarted during a reconfigure when there are no changes to
    keystone configuration.

    Add the common_options argument to the kolla_docker ansible module when
    checking the keystone containers and set it to docker_common_options.

    Change-Id: I44aefcf3d71faecaf1ffe384fd5a2f611e584a37
    Closes-Bug: #1759922
    (cherry picked from commit 735012c4bb4aaf83aa2eaadefde7b8b0a4674397)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/558106
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=4c1972200f97efe6d912b290b60e21a3b22cb73b
Submitter: Zuul
Branch: stable/pike

commit 4c1972200f97efe6d912b290b60e21a3b22cb73b
Author: Martin Chlumsky <email address hidden>
Date: Thu Mar 29 16:45:31 2018 -0400

    Add common_options to keystone container check

    keystone_* containers are created via the kolla_docker ansible module
    with common_options set to docker_common_options. However, when the
    containers are checked, common_options are not passed to the
    kolla_docker ansible module. This can cause the keystone_* containers
    to be restarted during a reconfigure when there are no changes to
    keystone configuration.

    Add the common_options argument to the kolla_docker ansible module when
    checking the keystone containers and set it to docker_common_options.

    Change-Id: I44aefcf3d71faecaf1ffe384fd5a2f611e584a37
    Closes-Bug: #1759922
    (cherry picked from commit 735012c4bb4aaf83aa2eaadefde7b8b0a4674397)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla-ansible 7.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla-ansible 6.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla-ansible 5.0.3 release.