The problem on the latest version of docker ipc_mode comparison

Bug #1747586 reported by wangwei
28
This bug affects 6 people
Affects Status Importance Assigned to Milestone
kolla-ansible
Fix Released
Undecided
wangwei

Bug Description

In my environment, I was using docker version 1.11.2, and if ipc_mode is not specified in kolla-ansible, then the default is None, as follows:
```
[root@pm-01 ~]# docker inspect ceph_mon | grep Ipc
            "IpcMode": "",
```

But lately I upgraded the docker version to 17.09.0-ce and replaced the storage backend with overlay2, so I used the upgrade command to recreate the ceph container, but then when I deployed a new osd, I found that all the ceph containers have been re-created, this should not happen, then I found the reason is ipc_mode different. In the newer version of docker, if you do not specify ipc_mode, the default value is no longer empty, but the following value:

```
"IpcMode": "shareable",
```

wangwei (wangwei-david)
Changed in kolla-ansible:
assignee: nobody → wangwei (wangwei-david)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (master)

Fix proposed to branch: master
Review: https://review.openstack.org/541160

Changed in kolla-ansible:
status: New → In Progress
Revision history for this message
Eduardo Gonzalez (egonzalez90) wrote :

To change storage backend will have to recreate containers again too. Mind sharing a link/commit/something to see the docker change for ip_mode?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (master)

Reviewed: https://review.openstack.org/541160
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=193ce726c242556416556869ed48c86e14b22632
Submitter: Zuul
Branch: master

commit 193ce726c242556416556869ed48c86e14b22632
Author: wangwei <email address hidden>
Date: Tue Feb 6 02:31:10 2018 -0500

    Fix ipc_mode comparison in the latest docker

    In old docker, if you do not specify ipc_mode, the default value is empty,
    but in the latest docker, such as 17.09.0, if not specified, the default
    is "IpcMode": "shareable", which will cause all containers to be deleted
    and re-create when to redeploy or upgrade. This commit solves the
    problem.

    Change-Id: Ia8269b9c8066880e4aee23d6fdea8d9c04c41e44
    Closes-Bug: #1747586

Changed in kolla-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/559877

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/559879

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/pike)

Reviewed: https://review.openstack.org/559879
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=ec4cd5b5925affe9b0b817662bb849b172cb97b8
Submitter: Zuul
Branch: stable/pike

commit ec4cd5b5925affe9b0b817662bb849b172cb97b8
Author: wangwei <email address hidden>
Date: Tue Feb 6 02:31:10 2018 -0500

    Fix ipc_mode comparison in the latest docker

    In old docker, if you do not specify ipc_mode, the default value is empty,
    but in the latest docker, such as 17.09.0, if not specified, the default
    is "IpcMode": "shareable", which will cause all containers to be deleted
    and re-create when to redeploy or upgrade. This commit solves the
    problem.

    Change-Id: Ia8269b9c8066880e4aee23d6fdea8d9c04c41e44
    Closes-Bug: #1747586
    (cherry picked from commit 193ce726c242556416556869ed48c86e14b22632)

tags: added: in-stable-pike
tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/queens)

Reviewed: https://review.openstack.org/559877
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=663142def93dfd79c65164ad412a0ce522b51a27
Submitter: Zuul
Branch: stable/queens

commit 663142def93dfd79c65164ad412a0ce522b51a27
Author: wangwei <email address hidden>
Date: Tue Feb 6 02:31:10 2018 -0500

    Fix ipc_mode comparison in the latest docker

    In old docker, if you do not specify ipc_mode, the default value is empty,
    but in the latest docker, such as 17.09.0, if not specified, the default
    is "IpcMode": "shareable", which will cause all containers to be deleted
    and re-create when to redeploy or upgrade. This commit solves the
    problem.

    Change-Id: Ia8269b9c8066880e4aee23d6fdea8d9c04c41e44
    Closes-Bug: #1747586
    (cherry picked from commit 193ce726c242556416556869ed48c86e14b22632)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/562123

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/ocata)

Reviewed: https://review.openstack.org/562123
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=fa54e2fe74df7b7bacc4ba220fae5b93e6e7d26f
Submitter: Zuul
Branch: stable/ocata

commit fa54e2fe74df7b7bacc4ba220fae5b93e6e7d26f
Author: wangwei <email address hidden>
Date: Tue Feb 6 02:31:10 2018 -0500

    Fix ipc_mode comparison in the latest docker

    In old docker, if you do not specify ipc_mode, the default value is empty,
    but in the latest docker, such as 17.09.0, if not specified, the default
    is "IpcMode": "shareable", which will cause all containers to be deleted
    and re-create when to redeploy or upgrade. This commit solves the
    problem.

    Change-Id: Ia8269b9c8066880e4aee23d6fdea8d9c04c41e44
    Closes-Bug: #1747586
    (cherry picked from commit 193ce726c242556416556869ed48c86e14b22632)

tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 7.0.0.0b2

This issue was fixed in the openstack/kolla-ansible 7.0.0.0b2 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 4.0.5

This issue was fixed in the openstack/kolla-ansible 4.0.5 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 6.1.0

This issue was fixed in the openstack/kolla-ansible 6.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 5.0.3

This issue was fixed in the openstack/kolla-ansible 5.0.3 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.