ovs-dpdkctl.sh function list_dpdk_nics only grabs first nic

Bug #1718240 reported by Charlie Kang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla-ansible
Fix Released
Undecided
Charlie Kang

Bug Description

ovs-dpdkctl.sh function list_dpdk_nics only grabs the first nic

Adding translate, new line in for loop /etc/default/ovs-dpdkctl.conf

function list_dpdk_nics {
    for nic in $(crudini --get $CONFIG_FILE ovs port_mappings | tr ',' '\n' | cut -d : -f 1); do
        echo $ni
    done
}

[root@ab11-07-wcp ~]# cat /etc/default/ovs-dpdkctl.conf
[ovs]
bridge_mappings = physnet1:br-ex
port_mappings = ens786f0:br-ens786f0,ens786f1:br-ens786f1
...

[root@ab11-07-wcp ~]# for nic in $(crudini --get /etc/default/ovs-dpdkctl.conf ovs port_mappings | cut -d: -f 1); do echo $nic; done
ens786f0

[root@ab11-07-wcp ~]# for nic in $(crudini --get /etc/default/ovs-dpdkctl.conf ovs port_mappings | tr ',' '\n' | cut -d: -f 1); do echo $nic; done
ens786f0
ens786f1

description: updated
Revision history for this message
Charlie Kang (charlie-kang) wrote :
Changed in kolla-ansible:
assignee: nobody → Charlie Kang (charlie-kang)
status: New → Fix Committed
Revision history for this message
Charlie Kang (charlie-kang) wrote :

Removed '' around pci_whitelist args for DPDK. When multiple entries
present vswitchd does not start.

Revision history for this message
sean mooney (sean-k-mooney) wrote :

the fix is not commited until it is merged

Changed in kolla-ansible:
status: Fix Committed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (master)

Reviewed: https://review.openstack.org/505319
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=26682ea78a9bcd525a97df2bb507e2edc9380682
Submitter: Zuul
Branch: master

commit 26682ea78a9bcd525a97df2bb507e2edc9380682
Author: Charlie Kang <email address hidden>
Date: Tue Sep 19 08:28:50 2017 -0700

    ovs-dpdkctl.sh function list_dpdk_nics only grabs the first nic

    Adding translate, new line in for loop /etc/default/ovs-dpdkctl.conf
    Removed '' around pci_whitelist args for DPDK. When multiple entries
    present vswitchd does not start.

    Closes-bug: #1718240

    Change-Id: I8196d56fe78e9ec1a0504059b98bcb9d1ee33f76

Changed in kolla-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 8.0.0.0b1

This issue was fixed in the openstack/kolla-ansible 8.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.