Nova role prechecks broken for baremetal-only compute

[Mark Goddard]

When using kolla-ansible in an environment with no virtualised compute hosts, e.g. one with only baremetal compute hosts, the following is seen during prechecks:

TASK [nova : Checking available compute nodes in inventory] ********************
fatal: [sv-b16-u23]: FAILED! => {"changed": false, "failed": true, "msg": "At least 1 compute node required in inventory"}
        to retry, use: --limit @/opt/alaska/alt-1/kayobe/ansible/kolla-venv/share/kolla-ansible/ansible/site.retry

PLAY RECAP *********************************************************************
sv-b16-u23 : ok=33 changed=0 unreachable=0 failed=1

Seen on kolla-ansible@161607f97c4316365b81f675432be4a9c08c0dd2.

This check should either be removed or only performed when enable_ironic is False.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/478993

[Mark Goddard (mgoddard)]

The check was introduced to fix this issue: https://bugs.launchpad.net/kolla-ansible/+bug/1686410

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/478993
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=d8a744e436d339cea73b6bc1835edaff8e4399c3
Submitter: Zuul
Branch: master

commit d8a744e436d339cea73b6bc1835edaff8e4399c3
Author: Mark Goddard <email address hidden>
Date: Thu Jun 29 17:26:22 2017 +0100

    Allow empty compute group when ironic is in use

    If ironic is in use it is valid to have no (virtualised) compute nodes.

    Change-Id: I100540fbfd81be5642c1d4ed135fcd500924a47e
    Closes-Bug: #1701317

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/530502

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/530502
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=02e8034d77af6b1f1e147ceaf78dad06b1de8fac
Submitter: Zuul
Branch: stable/pike

commit 02e8034d77af6b1f1e147ceaf78dad06b1de8fac
Author: Mark Goddard <email address hidden>
Date: Thu Jun 29 17:26:22 2017 +0100

    Allow empty compute group when ironic is in use

    If ironic is in use it is valid to have no (virtualised) compute nodes.

    Change-Id: I100540fbfd81be5642c1d4ed135fcd500924a47e
    Closes-Bug: #1701317
    (cherry picked from commit d8a744e436d339cea73b6bc1835edaff8e4399c3)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla-ansible 6.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla-ansible 5.0.2 release.