nova fake drivers deployment is broken after stable/ocata

[Matt Simonin]

Recent code updates[1][2] broke the support for nova fake drivers.
in [1], nova_services dict is introduce but the change is not refected in nova.conf.j2[3] when dealing with its elements.
in [2], two typos make neutron handlers to fail.

[1]: https://review.openstack.org/#/c/407416/
[2]: https://review.openstack.org/#/c/424504/
[3]: https://github.com/openstack/kolla-ansible/blob/master/ansible/roles/nova/templates/nova.conf.j2#L35

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/470214

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/470208
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=8e9cd4d278971022a1e34cff351dccfce1a8081b
Submitter: Jenkins
Branch: master

commit 8e9cd4d278971022a1e34cff351dccfce1a8081b
Author: msimonin <email address hidden>
Date: Fri Jun 2 10:47:25 2017 +0200

    Fix nova fake driver support

    Recent code updates[1][2] broke the support for nova fake drivers.
    in [1], nova_services dict is introduce but the change is not refected
    in nova.conf.j2[3] when dealing with its elements.
    in [2], two typos make neutron handlers to fail.

    [1]: https://review.openstack.org/#/c/407416/
    [2]: https://review.openstack.org/#/c/424504/
    [3]:
    https://github.com/openstack/kolla-ansible/blob/master/ansible/roles/nova/templates/nova.conf.j2#L35

    Change-Id: Ie32c76c4c902f1d95a1b4c97f8cbdb7ab101e48b
    Closes-bug: #1695218

[Francois Eleouet (fanchon)]

The same issue occurs with neutron fake driver, {{ item }} should probably be replaced by {{ service_name }} as it just has been done in nova in following places:

https://github.com/openstack/kolla-ansible/blob/5683b718456c5e149f6bfd291f84c24ee79c93e1/ansible/roles/neutron/templates/ml2_conf.ini.j2#L68
https://github.com/openstack/kolla-ansible/blob/5683b718456c5e149f6bfd291f84c24ee79c93e1/ansible/roles/neutron/templates/neutron.conf.j2#L32-L33

[Matt Simonin (matthieu-simonin)]

@fanchon thanks for raising this, my mistake I checked only nova after my deployment :(

Maybe a functionnal test on jenkins could have avoid this ?

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/470214
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=d1a0d97e1b4a691df6954f49ccef17dbec2e0756
Submitter: Jenkins
Branch: stable/ocata

commit d1a0d97e1b4a691df6954f49ccef17dbec2e0756
Author: msimonin <email address hidden>
Date: Fri Jun 2 10:47:25 2017 +0200

    Fix nova fake driver support

    Recent code updates[1][2] broke the support for nova fake drivers.
    in [1], nova_services dict is introduce but the change is not refected
    in nova.conf.j2[3] when dealing with its elements.
    in [2], two typos make neutron handlers to fail.

    [1]: https://review.openstack.org/#/c/407416/
    [2]: https://review.openstack.org/#/c/424504/
    [3]:
    https://github.com/openstack/kolla-ansible/blob/master/ansible/roles/nova/templates/nova.conf.j2#L35

    Change-Id: Ie32c76c4c902f1d95a1b4c97f8cbdb7ab101e48b
    Closes-bug: #1695218

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/472681

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla-ansible 5.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla-ansible 4.0.2 release.

[Mark Goddard (mgoddard)]

Xing Zhang, is it the same issue? It looks like this one was fixed. It would be better to raise a new bug for a new issue.

[Xing Zhang (xingzhang)]

I'm working on this one:
https://review.opendev.org/#/c/472681/

Seems this one was not fixed from 2017.

ANd related bug: https://bugs.launchpad.net/kolla-ansible/+bug/1746446