merge_config do not support multi key

Bug #1647065 reported by Jeffrey Zhang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla-ansible
Fix Released
High
Jeffrey Zhang

Bug Description

in openstack oslo_config, it support multi key config. like

[DEFAULT]
foo = bar1
foo = bar2

in the code, u will get

foo = [bar1, bar2]

But in kolla, we are using merge_config which leverage python standard ConfigParser package, it doesn't support multi key. and last value win, so after render, it will be like

[DEFAULT]
foo = bar2

in some service, they depends on multi key configuration. So this need to be fixed.

Changed in kolla:
status: New → Confirmed
importance: Undecided → High
Changed in kolla:
milestone: none → ocata-3
affects: kolla → kolla-ansible
Changed in kolla-ansible:
milestone: ocata-3 → none
Changed in kolla-ansible:
milestone: none → ocata-3
assignee: nobody → Jeffrey Zhang (jeffrey4l)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (master)

Fix proposed to branch: master
Review: https://review.openstack.org/412101

Changed in kolla-ansible:
status: Confirmed → In Progress
Revision history for this message
Jeffrey Zhang (jeffrey4l) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (master)

Reviewed: https://review.openstack.org/412101
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=910a50d8882a99e96e4005253c19a2895763085b
Submitter: Jenkins
Branch: master

commit 910a50d8882a99e96e4005253c19a2895763085b
Author: Jeffrey Zhang <email address hidden>
Date: Sun Dec 18 01:00:32 2016 +0800

    Support multi key in merge_config module

    Change-Id: Ibf9ee55c48a5181c5ba3aa46bef485cd3468f14c
    Closes-Bug: #1647065

Changed in kolla-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 4.0.0.0b3

This issue was fixed in the openstack/kolla-ansible 4.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.