kolla-ansible destroy cleanup OVS

Bug #1640178 reported by bjolo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla
Fix Released
High
Eduardo Gonzalez
Newton
Fix Released
Undecided
Magnus Lööf
kolla-ansible
Fix Released
High
Eduardo Gonzalez

Bug Description

kolla-ansible destroy does not clean up ovs. Reason is that ovs cleanup code is in cleanup_host.yml, and needs the ovs container to exec. The issue is that the ovs container is already removed in cleanup_containers.yml.

[root@eseldlx1042 ansible]# cat roles/destroy/tasks/main.yml
---
- include: copy_tools.yml

- include: cleanup_containers.yml

- include: cleanup_images.yml

- include: cleanup_host.yml

bjolo (bjorn-lofdahl)
Changed in kolla:
importance: Undecided → High
milestone: none → ocata-1
status: New → Confirmed
milestone: ocata-1 → 3.0.2
milestone: 3.0.2 → ocata-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla (master)

Fix proposed to branch: master
Review: https://review.openstack.org/396948

Changed in kolla:
status: New → In Progress
Changed in kolla:
milestone: ocata-1 → ocata-2
Changed in kolla:
milestone: ocata-2 → ocata-3
no longer affects: kolla/ocata
Changed in kolla-ansible:
status: New → In Progress
importance: Undecided → High
assignee: nobody → Eduardo Gonzalez (egonzalez90)
milestone: none → ocata-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (master)

Fix proposed to branch: master
Review: https://review.openstack.org/415873

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on kolla (master)

Change abandoned by Eduardo Gonzalez (<email address hidden>) on branch: master
Review: https://review.openstack.org/396948
Reason: moved to kolla-ansible

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (master)

Reviewed: https://review.openstack.org/415873
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=da83802b1b01eb442a551c19eddef063751d008b
Submitter: Jenkins
Branch: master

commit da83802b1b01eb442a551c19eddef063751d008b
Author: Eduardo Gonzalez <email address hidden>
Date: Sun Nov 13 16:15:08 2016 +0000

    Fix ovs-cleanup issue at cleanup scripts

    Move ovs-cleanup step to cleanup-containers,
    otherwise bridges will not be removed because neutron_openvswitch_agent
    container does not exists after running cleanup-containers.

    Add logic to cleanup ovs bridges only when openvswitch_db
    is removed and openvswitch-agent is running,
    so when removing other container from a parameter at script
    invocation ovs-cleanup will not be executed.

    Change-Id: Ie5fea40426df0e9e465fc173aba185f61098f676
    Closes-Bug: #1640178

Changed in kolla-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 4.0.0.0b3

This issue was fixed in the openstack/kolla-ansible 4.0.0.0b3 development milestone.

Changed in kolla:
milestone: ocata-3 → ocata-rc1
Changed in kolla:
milestone: ocata-rc1 → pike-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/435763

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/436122

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on kolla (stable/newton)

Change abandoned by Magnus Lööf (<email address hidden>) on branch: stable/newton
Review: https://review.openstack.org/435763
Reason: https://review.openstack.org/#/c/436122/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (stable/newton)

Reviewed: https://review.openstack.org/436122
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=a891947cc5dad45030af5517ebd895b2aa80e4c4
Submitter: Jenkins
Branch: stable/newton

commit a891947cc5dad45030af5517ebd895b2aa80e4c4
Author: Eduardo Gonzalez <email address hidden>
Date: Sun Nov 13 16:15:08 2016 +0000

    Fix ovs-cleanup issue at cleanup scripts

    Move ovs-cleanup step to cleanup-containers,
    otherwise bridges will not be removed because neutron_openvswitch_agent
    container does not exists after running cleanup-containers.

    Add logic to cleanup ovs bridges only when openvswitch_db
    is removed and openvswitch-agent is running,
    so when removing other container from a parameter at script
    invocation ovs-cleanup will not be executed.

    Change-Id: Ie5fea40426df0e9e465fc173aba185f61098f676
    Closes-Bug: #1640178
    (cherry picked from commit da83802b1b01eb442a551c19eddef063751d008b)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla 3.0.3

This issue was fixed in the openstack/kolla 3.0.3 release.

Changed in kolla:
milestone: pike-2 → pike-3
Changed in kolla:
milestone: pike-3 → pike-rc1
Changed in kolla:
milestone: pike-rc1 → queens-1
Changed in kolla:
milestone: queens-2 → queens-3
Changed in kolla:
milestone: queens-3 → queens-rc1
Changed in kolla:
milestone: queens-rc1 → queens-rc2
Changed in kolla:
milestone: queens-rc2 → rocky-1
Changed in kolla:
milestone: rocky-2 → rocky-3
Changed in kolla:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.