start.sh is duplicated in many images

Bug #1501295 reported by Sam Yaple
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla
Fix Released
High
Sam Yaple

Bug Description

The majority of the start.sh code is identical. We need to follow DRY and reduce that duplicated code.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla (master)

Fix proposed to branch: master
Review: https://review.openstack.org/229371

Changed in kolla:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (master)

Reviewed: https://review.openstack.org/229371
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=cb4e875ae1e1ec2e6ddf8a6b37f42283697fd50c
Submitter: Jenkins
Branch: master

commit cb4e875ae1e1ec2e6ddf8a6b37f42283697fd50c
Author: Sam Yaple <email address hidden>
Date: Wed Sep 30 11:23:39 2015 +0000

    Common start.sh

    The majority of the start.sh code is identical. This removes that
    duplicate code while still maintaining the ability to call code in a
    specific container.

    The start.sh is moved into /usr/local/bin/kolla_start in the container

    The extend_start.sh script is called by the kolla_start script at the
    location /usr/local/bin/kolla_extend_start . It always exists because
    we create a noop kolla_extend_start in the base directory. We override
    it with extend_start.sh in a specific image should we need to.

    Of note, the neutron-agents container is exempt from this new
    structure due to it being a fat container.

    Additionally, we fix the inconsistent permissions throughout. 644 for
    repo files and the scripts are set to 755 via a Docker RUN command to
    ensure someones local perm change won't break upstream containers.

    Change-Id: I7da8d19965463ad30ee522a71183e3f092e0d6ad
    Closes-Bug: #1501295

Changed in kolla:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/231311

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (stable/liberty)

Reviewed: https://review.openstack.org/231311
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=dc1983eff5f9ae38a4be2ab79a0505d0f96d0c40
Submitter: Jenkins
Branch: stable/liberty

commit dc1983eff5f9ae38a4be2ab79a0505d0f96d0c40
Author: Sam Yaple <email address hidden>
Date: Wed Sep 30 11:23:39 2015 +0000

    Common start.sh

    The majority of the start.sh code is identical. This removes that
    duplicate code while still maintaining the ability to call code in a
    specific container.

    The start.sh is moved into /usr/local/bin/kolla_start in the container

    The extend_start.sh script is called by the kolla_start script at the
    location /usr/local/bin/kolla_extend_start . It always exists because
    we create a noop kolla_extend_start in the base directory. We override
    it with extend_start.sh in a specific image should we need to.

    Of note, the neutron-agents container is exempt from this new
    structure due to it being a fat container.

    Additionally, we fix the inconsistent permissions throughout. 644 for
    repo files and the scripts are set to 755 via a Docker RUN command to
    ensure someones local perm change won't break upstream containers.

    Change-Id: I7da8d19965463ad30ee522a71183e3f092e0d6ad
    Closes-Bug: #1501295
    (cherry picked from commit cb4e875ae1e1ec2e6ddf8a6b37f42283697fd50c)

tags: added: in-stable-liberty
Sam Yaple (s8m)
Changed in kolla:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.