regression: git is required for ubuntu from source

[sean mooney]

build.ini

[neutron-base]
#type = url
#location = http://tarballs.openstack.org/neutron/neutron-master.tar.gz
type = git
location = https://github.com/openstack/neutron
reference = master

sudo tools/build.py -b ubuntu -t source neutron

building neutron form source on ubuntu form git fails with

:neutron-base:Processing /neutron
INFO:__main__:ceph-base:Setting up openssl (1.0.1f-1ubuntu2.15) ...
INFO:__main__:neutron-base: Complete output from command python setup.py egg_info:
INFO:__main__:neutron-base: ERROR:root:Error parsing
INFO:__main__:neutron-base: Traceback (most recent call last):
INFO:__main__:neutron-base: File "/usr/lib/python2.7/dist-packages/pbr/core.py", line 109, in pbr
INFO:__main__:neutron-base: attrs = util.cfg_to_args(path)
INFO:__main__:neutron-base: File "/usr/lib/python2.7/dist-packages/pbr/util.py", line 243, in cfg_to_args
INFO:__main__:neutron-base: pbr.hooks.setup_hook(config)
INFO:__main__:neutron-base: File "/usr/lib/python2.7/dist-packages/pbr/hooks/__init__.py", line 25, in setup_hook
INFO:__main__:neutron-base: metadata_config.run()
INFO:__main__:neutron-base: File "/usr/lib/python2.7/dist-packages/pbr/hooks/base.py", line 27, in run
INFO:__main__:neutron-base: self.hook()
INFO:__main__:neutron-base: File "/usr/lib/python2.7/dist-packages/pbr/hooks/metadata.py", line 26, in hook
INFO:__main__:neutron-base: self.config['name'], self.config.get('version', None))
INFO:__main__:neutron-base: File "/usr/lib/python2.7/dist-packages/pbr/packaging.py", line 668, in get_version
INFO:__main__:neutron-base: raise Exception("Versioning for this project requires either an sdist"
INFO:__main__:neutron-base: Exception: Versioning for this project requires either an sdist tarball, or access to an upstream git repository. Are you sure that git is installed?
INFO:__main__:neutron-base: error in setup command: Error parsing /tmp/pip-b3pDVh-build/setup.cfg: Exception: Versioning for this project requires either an sdist tarball, or access to an upstream git repository. Are you sure that git is installed?

this was previously addressed by
https://bugs.launchpad.net/kolla/+bug/1481560

but has reoccurred as git is not currently installed in the openstack base image for ubuntu following the conversion of the os specific dockerfiles to a common templates.

[sean mooney (sean-k-mooney)]

review link:
https://review.openstack.org/224288

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/224288
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=a242b51bbc80c1753398a64504bf8a52b2908bfe
Submitter: Jenkins
Branch: master

commit a242b51bbc80c1753398a64504bf8a52b2908bfe
Author: Sean Mooney <email address hidden>
Date: Wed Sep 16 21:19:25 2015 +0100

    Regression: git is required to build from source on ubuntu

    - this change fixes a regression of bug/1481560
    - this change re-adds git to the openstack base image
      when building images from source on ubuntu.
    - removed explicit git install from kolla-ansible

    Closes-Bug: #1496561
    Change-Id: Ia8a125e40bc6510af6d44c5317647be7ce27b0d6