Modifying a board preferences don't set the 'unsaved' flag

[Lorenzo Marcantonio]

To reproduce (as in today bzr):
- Open a board in pcbnew
- Enter, for example, Preferences/Dimensions/Texts and Drawings (other items *may* have the same issue)
- Change something then press OK
==> the 'save' command in not available, even if the changed preferences are in fact saved in the board file

WORKAROUND: touch something else and save or use 'save as'

[Krzysztof Wesołowski (kwesoly)]

I'm not 100% sure, but preferences you mentioned are saved in *.pro files, via Preferences->Save Preferences.

[Dimitar Kovachev (d-kovachev)]

Bump.

Unlike the original bug description, now changed preferences are NOT saved in the .BOR file and are effectively lost (unless another modification is done and the board saved).

Version: 0.0.201207131909+3646~10~precise1

[Dimitar Kovachev (d-kovachev)]

Sorry: ".BRD file"

[Stefan (stol)]

This can be confirmed.

In PcbNew there is a menu "Dimensions" with the sub menues
Grid
Texts And Drawings
Pads
Pad Mask Clearance
Diffrential Pairs
Save

Kicad uses a project file .pro and the pcbnew uses .kicad_pcb

B)
All the values in Grid/Pads/Pad Mask Clearance/Differental Paris
are saved in the .pro file and does not affect the .kicad_pcb

A)
All the values in "Texts And Drawings" is on the other hand
saved in the .kicad_pcb file.

This mean that any changes in B) must be followed by using the "Save" menu
choice, however using Save will not save any changes made in B)

But any changes made in B) will not "modify" pcbnew and therefore
these changes will be lost if the pcb is not modified in any other wy
like adding a track.

The follwing patch will "modify" the pcb if B) is modified
so the user can either save the changes in normal "pcb way"
or, at least, get a notification of unsaved data if exiting pcbnew without saving

 bzr push lp:~stol/kicad/bug793420
Using default stacking branch /+branch-id/324654 at chroot-67822224:///~stol/kicad/
Created new stacked branch referring to /+branch-id/324654.

[Stefan (stol)]

oups

It should be
A)
All the values in Grid/Pads/Pad Mask Clearance/Differental Paris
are saved in the .pro file and does not affect the .kicad_pcb

B)
All the values in "Texts And Drawings" is on the other hand
saved in the .kicad_pcb file.

[Wayne Stambaugh (stambaughw)]

A better short term solution would be to push the modified status down
to at least PCB_BASE_FRAME::SetDesignSettings() by first comparing the
new BOARD_DESIGN_SETTINGs against the existing ones in the board and
setting the modified flag accordingly to prevent false positives. Like
this:

void PCB_BASE_FRAME::SetDesignSettings( const BOARD_DESIGN_SETTINGS&
aSettings )
{
    wxASSERT( m_Pcb );

    if( m_Pcb->GetDesignSettings() != aSettings )
    {
        m_Pcb->SetDesignSettings( aSettings );
        OnModify();
    }
}

The ideal long term solution would be to keep track of the board
modification state within the BOARD object as it's modified but that is
a much more involved task.

On 9/22/2015 1:08 PM, Stefan wrote:
> oups
>
> It should be
> A)
> All the values in Grid/Pads/Pad Mask Clearance/Differental Paris
> are saved in the .pro file and does not affect the .kicad_pcb
>
> B)
> All the values in "Texts And Drawings" is on the other hand
> saved in the .kicad_pcb file.
>

[Stefan (stol)]

I agree, but the solution was a quick one, so it could go in easier due to the block of new features until the stable release.

Perhaps the "Save" menu should be removed as well.
Aas soon as you click on the OK button for category "Grid/Pads/Pad Mask Clearance/Differental Paris"
it would mean an update of the .pro file directly instead of "waiting" for the save button.

[Novak Tamas (novak-7)]

It seems to be solved (BZR 6658), as modifying e.g. Page settings - Revision enables Save button. When Save is clicked, KiCad_PDB is written, but .pro is not modified.

[Nick Østergaard (nickoe)]

@Novak, did you test this in 4.0.2? If not and it works in latest product, then it should just be marked as fix comitted.

[Novak Tamas (novak-7)]

Sorry, it works well (save button enabled after changing something) for Page Settings - Revision, but doesn't work when editing Preferences - General - Units. The same with both BZR6709 and 4.0.2_stable). Gotta set back to "confirmed":(

[xzcvczx (xzcvczx)]

This also occurs if you change layer visibility without changing anything else you are unable to save which layers are visible

[Jeff Young (jeyjey)]

Layer visibility fixed in:

 https://github.com/KiCad/kicad-source-mirror/commit/8722fd9c6c327407d7fe285e944830b1a9a9c57b

I considered Wayne's recommendation of doing the Design Settings at the SCH_BASE_FRAME level, but we'd need to write a whole boatload of operator== routines to make that work, and it would be inconsistent with most of the rest of the app which sets modified at the UI level.

The patch therefore fixes all callers of SetDesignSettings (both PCB_BASE_FRAME and SCH_BASE_FRAME), as well as callers of SetZoneSettings.

[Wayne Stambaugh (stambaughw)]

I merged your patch. I know it's not the ideal solution but if resolves this bug. Thanks

[KiCad Janitor (kicad-janitor)]

Fixed in revision b1b3a89f72263168efd08ea9fc30c26b5cbdf1cb
https://git.launchpad.net/kicad/patch/?id=b1b3a89f72263168efd08ea9fc30c26b5cbdf1cb