minizip's CMakeLists.txt sets "wrong" libwxzlib to linker

Bug #639601 reported by Heiko Lechner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Fix Released
Undecided
Unassigned

Bug Description

In CMakeLists.txt the wxzlib is set to "${wxWidgets_ROOT_DIR}/lib/libwxzlib-2.8.a" but it must be set to "${wxWidgets_LIB_DIR}/libwxzlib.a"

Revision history for this message
Heiko Lechner (no-spam-to-me) wrote :
Revision history for this message
jean-pierre charras (jp-charras) wrote : Re: [Bug 639601] [NEW] minizip's CMakeLists.txt sets "wrong" libwxzlib to linker

Le 15/09/2010 16:22, Heiko Lechner a écrit :
>
> Public bug reported:
>
> In CMakeLists.txt the wxzlib is set to
> "${wxWidgets_ROOT_DIR}/lib/libwxzlib-2.8.a" but it must be set to
> "${wxWidgets_LIB_DIR}/libwxzlib.a"
>
> ** Affects: kicad
> Importance: Undecided
> Status: New
>

On my computer, under Windows, this lib is really:
${wxWidgets_ROOT_DIR}/lib/libwxzlib-2.8.a

With the wxWidgets standard install.

--
Jean-Pierre CHARRAS
KiCad Developers team.
KiCad Developers <email address hidden>

Revision history for this message
Heiko Lechner (no-spam-to-me) wrote : Re: [Bug 639601] [NEW] minizip's CMakeLists.txt sets "wrong" libwxzlib to linker

Am 15.09.2010 16:44, schrieb jean-pierre charras:

> On my computer, under Windows, this lib is really:
> ${wxWidgets_ROOT_DIR}/lib/libwxzlib-2.8.a
>
> With the wxWidgets standard install.

I have wxMSW-2.8.11 compiled from source with MinGW using makefile.gcc
and mingw32-make (no MSYS).

I only have ${wxWidgets_ROOT_DIR}/lib/gcc_dll/libwxzlib.a

Something has to be done with CMakeLists.txt.

TIA, Heiko.

Revision history for this message
Heiko Lechner (no-spam-to-me) wrote :

I asked in the wxwidgets forum and /gcc_dll/libwxzlib.a seems to be build using MinGW makefile solely.
libwxzlib-2.8.a will be build using configure (under Windows with MSYS).

So I suggest the following in CMakeLists.txt:
find_file(ZLIB_LIBRARIES NAMES libwxzlib-2.8.a libwxzlib.a PATHS ${wxWidgets_ROOT_DIR}/lib/ PATH_SUFFIXES gcc_dll DOC "location of wxzlib library file")

That should work for both of us ;)

I included a Diff- File.

Changed in kicad:
status: New → Fix Committed
Jon Neal (reportingsjr)
Changed in kicad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.