Impossible to undo track and module mode actions in PCBnew

[Camille019]

It is impossible to undo an edition realised in the Modules Mode or in the Track Mode. I am obliged to close PCBnew without saving to cancel the edition.

To reproduce the bug:

Modules Mode -> right click on a module -> Auto Place Module, it is impossible to undo this edition.
It is the same with the "Global Move and Place" actions.

Track Mode -> right click -> Autoroute -> Autoroute All Modules, it is impossible to undo this edition.

System : Ubuntu 10.04
KiCad version : lp:kicad/stable bzr2356
KiCad App : PCBnew

[Stephen Eaton (seaton)]

confirmed also on windows version version bzr2356.

Undo menu Item is active (not greyed out), but will not work when clicked

[Guillaume Simard (gsimard)]

Here is a patch for this bug. Undo functionality has been added for:

automove
autoplace
autoroute

Guillaume

[Wayne Stambaugh (stambaughw)]

On 12/13/2011 9:34 AM, Guillaume Simard wrote:
> Here is a patch for this bug. Undo functionality has been added for:
>
> automove
> autoplace
> autoroute
>
> Guillaume
>
> ** Patch added: "pcbnew_undo.patch"
> https://bugs.launchpad.net/kicad/+bug/577618/+attachment/2631447/+files/pcbnew_undo.patch
>
A minor comment on your patch. Your editor's auto indent feature is leaving
trailing white space. If you editor has a clean up trailing white space
feature or macro, please use it before submitting your patches. This is
documented in KiCad coding policy.

Thanks,

Wayne

[Guillaume Simard (gsimard)]

You're right two lines had trailing whitespace, sorry about that.

I've added a call to (delete-trailing-whitespace) on a write hook for my emacs configuration file so this shouldn't happen anymore.

Are all the source files in the KiCad project devoid of trailing whitespace ? I'm asking just to make sure I won't trigger diff after my editor automatically removes all trailing whitespace of every file I visit.

Thank you,
Guillaume

[Wayne Stambaugh (stambaughw)]

On 12/13/2011 11:47 AM, Guillaume Simard wrote:
> You're right two lines had trailing whitespace, sorry about that.
>
> I've added a call to (delete-trailing-whitespace) on a write hook for my
> emacs configuration file so this shouldn't happen anymore.
>
> Are all the source files in the KiCad project devoid of trailing
> whitespace ? I'm asking just to make sure I won't trigger diff after my
> editor automatically removes all trailing whitespace of every file I
> visit.

They should be. A couple of years ago I ran uncrustify on every source code
file that removed all of the trailing white space. That doesn't mean that that
some more hasn't crept in here and there. I have the show-trailing-whitespace
variable set to t in my Emacs configuration so I am painfully aware of any
trailing white space. If you have your editor set up to remove trailing white
space and it causes a diff then I'm OK with that because the trailing white
space shouldn't be in there any way. Don't worry fixing your patch. I have
already applied to my branch and cleaned it up. I have some more testing to do
but I should get it committed soon.

Thanks for helping,

Wayne

>
> Thank you,
> Guillaume
>