Commit f23e151b907 breaks compilation on Windows

[jean-pierre charras]

Commit f23e151b907 (Use wxArrayString instead of vector<wxString> in BUS_ALIAS) breaks compilation (at least on msys2) each time the code try to copy a wxArrayString into a std::vector<wxString>.

The error message is:
F:/kicad-launchpad/git_testing/eeschema/netlist_object.cpp: In member function 'void NETLIST_OBJECT::ConvertBusToNetListItems(NETLIST_OBJECT_LIST&)':
F:/kicad-launchpad/git_testing/eeschema/netlist_object.cpp:254:47: error: no match for 'operator=' (operand types are 'std::vector<wxString>' and 'wxArrayString')
  254 | bus_contents_vec = alias->Members();
      | ^
In file included from C:/msys32/mingw32/include/c++/9.2.0/vector:72,
                 from D:/wxWidgets-3.1.3/include/wx/arrstr.h:19,
                 from D:/wxWidgets-3.1.3/include/wx/wx.h:21,
                 from F:/kicad-launchpad/git_testing/include/fctsys.h:28,
                 from F:/kicad-launchpad/git_testing/eeschema/netlist_object.cpp:31:
C:/msys32/mingw32/include/c++/9.2.0/bits/vector.tcc:198:5: note: candidate: 'std::vector<_Tp, _Alloc>& std::vector<_Tp, _Alloc>::operator=(const std::vector<_Tp, _Alloc>&) [with _Tp = wxString; _Alloc = std::allocator<wxString>]'
  198 | vector<_Tp, _Alloc>::
      | ^~~~~~~~~~~~~~~~~~~
C:/msys32/mingw32/include/c++/9.2.0/bits/vector.tcc:199:42: note: no known conversion for argument 1 from 'wxArrayString' to 'const std::vector<wxString>&'
  199 | operator=(const vector<_Tp, _Alloc>& __x)

[Wayne Stambaugh (stambaughw)]

It also breaks linux builds.

[Wayne Stambaugh (stambaughw)]

@Jon, when making changes to fix build errors on VS, please check that the changes build at a minimum on linux. How soon can you get around to fixing this? I was planning on disabling the launchpad repo this morning.

[KiCad Janitor (kicad-janitor)]

Fixed in revision d20d310fccdbbc65cca2da63f58cede4fba3a357
https://git.launchpad.net/kicad/patch/?id=d20d310fccdbbc65cca2da63f58cede4fba3a357

[Seth Hillbrand (sethh)]

Jon, feel free to modify this fix if you have a better one in mind

[Jon Evans (craftyjon)]

Sorry, I did not see this until just now. Thanks for fixing it, Seth