Comment 7 for bug 1852899

@Fabien, the behavior in the video is the behavior I am seeing when I use your patch. I am not sure what is going on here though, since it appears that it is pulling from the high contrast colors for the via netnames layer when it should now. For some reason the via net label is changing colors still.

I have attached a video showing what I see when using your patch, with a slight modification to see what was happening. The output in the terminal are some debug statements I have placed into the color logic (in pcb_painter.cpp) to see what color it was pulling:

if( viaActiveLayer )
{
    if( aLayer == LAYER_VIAS_NETNAMES )
        wxLogDebug( "Via normal" );

    return m_layerColors[aLayer];
}
else
{
    if( aLayer == LAYER_VIAS_NETNAMES )
        wxLogDebug( "Via high contrast" );

    return m_hiContrastColor[aLayer];
}

Based on that it appears to be pulling the high contrast color each time, but for some reason switching to/from the copper layer changes it again. Is there another part of the code that you modified that didn't get included in the patch?