eeschema: On a net label with curly braces the closing one is reverted

[Dino Ghilardi]

To recreate:
-Open eeschema
-Add a net label
-write "CAN{CAN}"
-place the label: the label "CAN{CAN{" (wrong last parenthesis) is placed on the schematic sheet.

Tested on master branch,
5.1.2 is not affected by this bug.
5.1.5rc1 is not affected by this bug.

Cheers,
Dino.

-----------------------------
Application: Eeschema
Version: (5.99.0-360-ga6b94b37e-dirty), release build
Libraries:
    wxWidgets 3.0.2
    libcurl/7.52.1 GnuTLS/3.5.8 zlib/1.2.8 libidn2/0.16 libpsl/0.17.0 (+libidn2/0.16) libssh2/1.7.0 nghttp2/1.18.1 librtmp/2.3
Platform: Linux 4.9.0-8-amd64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    Build date: Nov 12 2019 19:01:23
    wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.69.0
    OpenCASCADE Community Edition: 6.8.0
    Curl: 7.52.1
    Compiler: GCC 6.3.0 with C++ ABI 1010

Build settings:
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Ian McInerney (imcinerney)]

Can you provide a schematic that does this reliably? I tried inserting a label "CAN{CAN}" onto a blank Eeschema sheet and it appeared correctly when placed.

Application: Eeschema
Version: (5.99.0-366-g56949252b-dirty), debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.65.3 OpenSSL/1.1.1c-fips zlib/1.2.11 brotli/1.0.7 libidn2/2.2.0 libpsl/0.20.2 (+libidn2/2.0.5) libssh/0.9.0/openssl/zlib nghttp2/1.38.0
Platform: Linux 5.1.18-300.fc30.x86_64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    Build date: Nov 14 2019 15:51:44
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.24
    Boost: 1.69.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.65.3
    Compiler: Clang 8.0.0 with C++ ABI 1002

Build settings:
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON
    KICAD_STDLIB_DEBUG=OFF
    KICAD_STDLIB_LIGHT_DEBUG=ON
    KICAD_SANITIZE=ON

[Dino Ghilardi (dino-ghilardi)]

I'm re-compiling now after a git clean -fx; make clean; make, to see if it is an effect of a "dirty" build.

[Dino Ghilardi (dino-ghilardi)]

(on my machine it happens also on an empty project, adding "net label", When the re-compile is complete I'll be able to say if the "cleaned" version works)

[Dino Ghilardi (dino-ghilardi)]

(...still waiting for compilation): Placing a text (not a net label) does not show the issue.

[Dino Ghilardi (dino-ghilardi)]

I still have that after "clean" recompilation.
Attached a video of the behaviour.
P.S: Editing the label you can change it to the right one.
(it is just like if there is something wrong in the code that escapes the braces that are also used for bus definition, but this is only an hypothesis since I did not look into the code)

Application: Eeschema
Version: (5.99.0-366-g56949252b-dirty), release build
Libraries:
    wxWidgets 3.0.2
    libcurl/7.52.1 GnuTLS/3.5.8 zlib/1.2.8 libidn2/0.16 libpsl/0.17.0 (+libidn2/0.16) libssh2/1.7.0 nghttp2/1.18.1 librtmp/2.3
Platform: Linux 4.9.0-8-amd64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    Build date: Nov 14 2019 17:27:18
    wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.69.0
    OpenCASCADE Community Edition: 6.8.0
    Curl: 7.52.1
    Compiler: GCC 6.3.0 with C++ ABI 1010

Build settings:
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Dino Ghilardi (dino-ghilardi)]

Attached a project with braces reversed. Cheers, Dino.

[Nick Østergaard (nickoe)]

@Michael, why did you mark this incomplete? He provided a test project.

[Dino Ghilardi (dino-ghilardi)]

Also I added a small screen grab video.

The strange thing about this behaviour is that after a git clean -fx/make clean/make it is still there, but Ian did not see that with a similar configuration. Now I'm trying to re-clean everything and also re-generate the makefiles with cmake, to see if it is a problem on my build only.

[Dino Ghilardi (dino-ghilardi)]

After updating (git pull), re-generating makefiles (with cmake-gui) and re-compiling still have the reversed end curly bracket..

-----
Application: Eeschema
Version: (5.99.0-369-g544867cf2-dirty), release build
Libraries:
    wxWidgets 3.0.2
    libcurl/7.52.1 GnuTLS/3.5.8 zlib/1.2.8 libidn2/0.16 libpsl/0.17.0 (+libidn2/0.16) libssh2/1.7.0 nghttp2/1.18.1 librtmp/2.3
Platform: Linux 4.9.0-8-amd64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    Build date: Nov 15 2019 14:44:38
    wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.69.0
    OpenCASCADE Community Edition: 6.8.0
    Curl: 7.52.1
    Compiler: GCC 6.3.0 with C++ ABI 1010

Build settings:
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Dino Ghilardi (dino-ghilardi)]

...Weird.... I tested on another debian linux machine (more recent distro) an I did not see the bug there. I suspect it is related to some difference in libraries. Now I'm recompiling also there, to see if the behaviour appears on more recent commits.

------------------------------------------
Application: Eeschema
Version: (5.99.0-314-ga60fb9a4b), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.64.0 OpenSSL/1.1.1d zlib/1.2.11 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) libssh2/1.8.0 nghttp2/1.36.0 librtmp/2.3
Platform: Linux 4.19.0-6-amd64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    Build date: Nov 6 2019 11:24:19
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.24
    Boost: 1.67.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.64.0
    Compiler: GCC 8.3.0 with C++ ABI 1013
Build settings:
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=OFF

[Ian McInerney (imcinerney)]

Yea, this one is odd. I still can't seem to recreate it on my machine.

@Dino, are you running with a different language selected? I note that your cancel button is translated (but other places aren't).

[Dino Ghilardi (dino-ghilardi)]

@Ian: Even after an <<export LC_ALL="C">> before lauching kicad I have that button translated in italian (probably the wxWidgets or gtk still keep the "it_IT UTF-8" system-wide locale). in kicad I selected the "default" language.

[KiCad Janitor (kicad-janitor)]

Fixed in revision a89dc98e07524fd0b821630f40da602eecf4366b
https://git.launchpad.net/kicad/patch/?id=a89dc98e07524fd0b821630f40da602eecf4366b

[Michael Kavanagh (michaelkavanagh)]

@Nick, it was a mistake, my apologies.