Eeschema: Clear Annotations not working [MSW 10]

[Robert Garnett]

When the clear annotations button is pressed the program does not clear the annotations. The cancel button does not work, but the windows title bar close of the clear annotations dialog does close the dialog. I noticed this bug in Windows Nightly: kicad-r14355.3fffd042d-x86_64. It was still evident in kicad-r14358.e621ae753-x86_64.exe.

It was not present in:

Application: KiCad
Version: (5.99.0-229-g5b8661f2a), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.1 OpenSSL/1.1.1 (WinSSL) zlib/1.2.11 brotli/1.0.6 libidn2/2.0.5 libpsl/0.21.0 (+libidn2/2.1.1) nghttp2/1.34.0
Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    Build date: Oct 16 2019 21:05:43
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.68.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.1
    Compiler: GCC 8.2.0 with C++ ABI 1013
Build settings:
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[jean-pierre charras (jp-charras)]

It works for me.

[Jeff Young (jeyjey)]

I can't trigger this either. I tried both with the warning dialog and with "Don't show again" checked.

[Michael Kavanagh (michaelkavanagh)]

Can you upload an example schematic file?

[Robert Garnett (rjg)]

Hi,

Definitely doesn't work for me.

I have attached the project and also a screen shot of the schematic with the Clear Annotations dialog after I have pushed the clear annotations button.

Annotations are all still there as you can see.

Also the cancel button does nothing as I said, but the close window button in the dialog title bar does work.

Best regards

Rob.

P.S the latest nightly has the problem also:

Application: KiCad
Version: (5.99.0-278-g4135f0c0e), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.66.0 OpenSSL/1.1.1d (Schannel) zlib/1.2.11 brotli/1.0.7 libidn2/2.2.0 libpsl/0.21.0 (+libidn2/2.1.1) nghttp2/1.39.2
Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    Build date: Oct 31 2019 22:07:44
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.71.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.66.0
    Compiler: GCC 9.2.0 with C++ ABI 1013

Build settings:
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Michael Kavanagh (michaelkavanagh)]

Works fine for me on macOS. I cannot see any screenshot in the zip file you attached, did you forget to include it?

Application: Eeschema
Version: (5.99.0-278-g4135f0c0e), debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.64.1 SecureTransport (LibreSSL/2.8.3) zlib/1.2.11 nghttp2/1.39.2
Platform: Mac OS X (Darwin 19.0.0 x86_64), 64 bit, Little endian, wxMac
Build Info:
    Build date: Oct 30 2019 21:00:16
    wxWidgets: 3.0.4 (wchar_t,STL containers,compatible with 2.8)
    Boost: 1.70.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.54.0
    Compiler: Clang 11.0.0 with C++ ABI 1002

Build settings:
    KICAD_SCRIPTING=OFF
    KICAD_SCRIPTING_MODULES=OFF
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=OFF
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=OFF
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON
    KICAD_STDLIB_DEBUG=OFF
    KICAD_STDLIB_LIGHT_DEBUG=OFF
    KICAD_SANITIZE=OFF

[Robert Garnett (rjg)]

Hi,

Sorry about the screen shot.

Here it is.

I'm running Windows 10. Can't afford a Mac.

I will try a new nightly build and fiddle around with the file to see if I can work anything out.

Best regards

ROb

[Robert Garnett (rjg)]

Hi,

As promised I downloaded yesterdays Nightly and tested it on the project I sent you. Bug still occurs.

I then copied an older more complex project that I had completed and tried it on that. Same result.

An interesting point I found is that if you check the warning dialog and close it and then try again, the warning dialog does not appear, which is the required behavior, but then pressing clear annotations still does not do the business.

It's real pain for me as I use the clear annotation quite a lot, particularly for board revisions.

Best regards

Rob

[jean-pierre charras (jp-charras)]

This not a warning dialog, this is a confirmation dialog.
You have to click on "Clear Annotation" button of this confirmation dialog to clear the annotation.
Closing it is cancelling the command.

[Robert Garnett (rjg)]

Hi,

I might not have explained the confirmation dialog behaviour correctly in my last comment.

When I do the following;

Step 1 Push "Clear Annotation Button The confirmation Dialog opens
Step 2 Set the "Do not show again" check box of the confirmation dialog
Step 3 Push "Clear Annotation" Push button of the confirmation dialog (Nothing Happens)
Step 4 Push the "cancel Button" of the confirmation dialog (Nothing Happens)
Step 5 Push the "Window Close: Push button in the title bar of the confirmation dialog (Confirmation dialog closes)
Step 6 Push "Annotate" push button of the Annotate Schematic main dialog (Nothing Happens - The confirmation dialog does not open, but the annotations are NOT reset.

What this basically says is the confirmation"Do not show again" logic is working, but the clear annotations function is not working no matter which dialog you initiate the clear dialog function from, i.e. the confirmation dialog or the main annotation dialog.

Please see screen shots attached

Best regards

Rob

[Robert Garnett (rjg)]

Hi,

I might not have explained the confirmation dialog behaviour correctly in my last comment.

When I do the following;

Step 1 Push "Clear Annotation Button The confirmation Dialog opens
Step 2 Set the "Do not show again" check box of the confirmation dialog
Step 3 Push "Clear Annotation" Push button of the confirmation dialog (Nothing Happens)
Step 4 Push the "cancel Button" of the confirmation dialog (Nothing Happens)
Step 5 Push the "Window Close: Push button in the title bar of the confirmation dialog (Confirmation dialog closes)
Step 6 Push "Annotate" push button of the Annotate Schematic main dialog (Nothing Happens - The confirmation dialog does not open, but the annotations are NOT reset.

What this basically says is the confirmation"Do not show again" logic is working, but the clear annotations function is not working no matter which dialog you initiate the clear dialog function from, i.e. the confirmation dialog or the main annotation dialog.

Please see screen shots attached

Best regards

Rob

[Robert Garnett (rjg)]

Hi

Still does not work in following version.

Application: KiCad
Version: (5.99.0-393-gd4cea0f2b), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.66.0 OpenSSL/1.1.1d (Schannel) zlib/1.2.11 brotli/1.0.7 libidn2/2.2.0 libpsl/0.21.0 (+libidn2/2.1.1) nghttp2/1.39.2
Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    Build date: Nov 18 2019 19:40:04
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.71.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.66.0
    Compiler: GCC 9.2.0 with C++ ABI 1013

Build settings:
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Best regards

Rob

[Robert Garnett (rjg)]

Hi

Still does not work in following version.

Application: KiCad
Version: (5.99.0-417-g8bd2765f3), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.66.0 OpenSSL/1.1.1d (Schannel) zlib/1.2.11 brotli/1.0.7 libidn2/2.2.0 libpsl/0.21.0 (+libidn2/2.1.1) nghttp2/1.39.2
Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    Build date: Nov 24 2019 22:10:45
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.71.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.66.0
    Compiler: GCC 9.2.0 with C++ ABI 1013

Build settings:
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Is there any testing I can do to get to the bottom of this problem?

Best regards

Rob

[Seth Hillbrand (sethh)]

We are unable to reproduce this issue. Can you please make a screen capture video of the process?

[Robert Garnett (rjg)]

Hi

Still does not work in following version.

Application: KiCad
Version: (5.99.0-417-g8bd2765f3), release build

I made a three component schematic.

I ran the annotation tool from the toolbar and it annoted the three parts correctly.

I then tried the Clear Annotations button. nothing happened.

I then renumberd the components and included the ? for the phot resistor. I then selected:

- Use entire schematic
- Reset, but keep order of multi-unit parts

I then pressed annotate and the schematic was correctly re-annoted.

It would appear that the "Clear Annotation" button is not calling anything on my system

Best regards

Rob

[Robert Garnett (rjg)]

Hi

Please find attached a zip of the above test.

[Robert Garnett (rjg)]

Hi Seth,

I just sent a couple of posts.

The last one has the project files and screen shots.

I'll attach the zip to this email also.

I have Windows 10 - see screenshot of WinVer attached.

Are there anything on my system you would like me to check?

Best regards

Rob

On 25/11/2019 15:08, Seth Hillbrand wrote:
> We are unable to reproduce this issue. Can you please make a screen
> capture video of the process?
>

[Seth Hillbrand (sethh)]

Yes. Video not screenshot.

[Robert Garnett (rjg)]

Ok

I am having trouble with snagit which I use for my vids.

What do you use?

Best regards

Rob

[Robert Garnett (rjg)]

Here is a Vi

Best regards

Rob

[Seth Hillbrand (sethh)]

Thank you. This was what we needed. It looks like the events are not getting connected right for that window.

Does anyone have Windows 10 to hand to reproduce this issue?

[Robert Garnett (rjg)]

Yep,

That's what it looks like as everything else works well.

Best regards

Rob

On 27/11/2019 01:27, Seth Hillbrand wrote:
> Thank you. This was what we needed. It looks like the events are not
> getting connected right for that window.
>
> Does anyone have Windows 10 to hand to reproduce this issue?
>
> ** Changed in: kicad
> Status: Incomplete => New
>

[KiCad Janitor (kicad-janitor)]

KiCad bug tracker has moved to Gitlab. This report is now available here: https://gitlab.com/kicad/code/kicad/-/issues/1942