Segfault on changing edit settings while simulating

Bug #1849492 reported by Seth Hillbrand on 2019-10-23
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Fix Committed
Undecided
Seth Hillbrand

Bug Description

Open the simulator window in Eeschema
Go back to Eeschema and change one of the preferences in the preference window
Click OK.

It appears that EDA_BASE_FRAME expects all children to provide an action manager but the simulator window does not.

Application: KiCad
Version: (5.99.0-252-ge621ae753-dirty), debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.64.0 OpenSSL/1.1.1d zlib/1.2.11 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) libssh2/1.8.0 nghttp2/1.36.0 librtmp/2.3
Platform: Linux 4.19.0-6-amd64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    Build date: Sep 29 2019 11:57:35
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.24
    Boost: 1.67.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.64.0
    Compiler: GCC 8.3.0 with C++ ABI 1013

Build settings:
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON
    KICAD_STDLIB_DEBUG=OFF
    KICAD_STDLIB_LIGHT_DEBUG=OFF
    KICAD_SANITIZE=OFF

#0 0x00007fffe0f69938 in TOOL_MANAGER::GetActionManager() (this=0x0) at ../../include/tool/tool_manager.h:163
#1 0x00007fffe0f66174 in EDA_BASE_FRAME::CommonSettingsChanged(bool) (this=0x55555a7836e0, aEnvVarsChanged=false)
    at ../../common/eda_base_frame.cpp:396
#2 0x00005555556b3ee1 in KIWAY::CommonSettingsChanged(bool) (this=0x5555558de260 <Kiway>, aEnvVarsChanged=false)
    at ../../common/kiway.cpp:478
#3 0x00007fffe0f679c7 in EDA_BASE_FRAME::OnPreferences(wxCommandEvent&) (this=0x55555a603460, event=...)
    at ../../common/eda_base_frame.cpp:640
#4 0x00007ffff74a77ae in wxEvtHandler::ProcessEventIfMatchesId(wxEventTableEntryBase const&, wxEvtHandler*, wxEvent&) () at /usr/lib/x86_64-linux-gnu/libwx_baseu-3.0.so.0
#5 0x00007ffff74a78b3 in wxEventHashTable::HandleEvent(wxEvent&, wxEvtHandler*) ()
    at /usr/lib/x86_64-linux-gnu/libwx_baseu-3.0.so.0
#6 0x00007ffff74a7bec in wxEvtHandler::TryHereOnly(wxEvent&) () at /usr/lib/x86_64-linux-gnu/libwx_baseu-3.0.so.0
#7 0x00007fffe0f65529 in EDA_BASE_FRAME::ProcessEvent(wxEvent&) (this=0x55555a603460, aEvent=...)
    at ../../common/eda_base_frame.cpp:253
#8 0x00007ffff74a7a73 in wxEvtHandler::DoTryChain(wxEvent&) () at /usr/lib/x86_64-linux-gnu/libwx_baseu-3.0.so.0
#9 0x00007ffff74a7d11 in wxEvtHandler::ProcessEvent(wxEvent&) () at /usr/lib/x86_64-linux-gnu/libwx_baseu-3.0.so.0
#10 0x00007ffff7a0940b in wxWindowBase::TryAfter(wxEvent&) (this=0x5555685606b0, event=...)
    at ../include/wx/window.h:846
#11 0x00007ffff74a7ab7 in wxEvtHandler::SafelyProcessEvent(wxEvent&) ()
    at /usr/lib/x86_64-linux-gnu/libwx_baseu-3.0.so.0
#12 0x00007ffff7a0a92c in wxWindowBase::HandleWindowEvent(wxEvent&) const (this=<optimized out>, event=...)
    at ../include/wx/window.h:846
#13 0x00007ffff79c09e5 in wxMenuBase::SendEvent(int, int)
    (this=this@entry=0x555565cbc250, itemid=itemid@entry=5022, checked=<optimized out>)

KiCad Janitor (kicad-janitor) wrote :

Fixed in revision a934fa49aa9e77fdccd10821bcfbe0a63cce35d3
https://git.launchpad.net/kicad/patch/?id=a934fa49aa9e77fdccd10821bcfbe0a63cce35d3

Changed in kicad:
status: New → Fix Committed
assignee: nobody → Seth Hillbrand (sethh)
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers