Blind/Buried/uVia holes shown in High Contrast Mode

[Tim N. Tashpulatov]

Application: Pcbnew
Version: (5.1.4)-1, release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.1 OpenSSL/1.1.1 (WinSSL) zlib/1.2.11 brotli/1.0.6 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) nghttp2/1.34.0
Platform: Windows 7 (build 7601, Service Pack 1), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.68.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.1
    Compiler: GCC 8.2.0 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

When working in High Contrast Mode, Blind/Buried/Microvia holes are not dimmed even if they don't belong to active layer.

In example attached, 4-layer board has two Vias. Left one is Buried Via on In1 and In2 layers, right is plain Via through all four layers. When Top or Bottom layer is selected with High Contrast Mode active, Buried Via's drill hole is still shown. It would be less misguiding if holes for Vias that do not belong to current layer would be dimmed.

[Tim N. Tashpulatov (tim-tashpulatov)]

Can be duplicate of this one - https://bugs.launchpad.net/kicad/+bug/1737594

[Wayne Stambaugh (stambaughw)]

@Tim, did you forget to attach the sample board?

[Tim N. Tashpulatov (tim-tashpulatov)]

Did not attach real one, being rather big (1.5Mb netlist file, 6Mb PCB file).

Attaching sample I've just made at home with Linux version of KiCad, showing the same behavior.

Application: Pcbnew
Version: 5.1.4-e60b266~84~ubuntu18.04.1, release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.58.0 OpenSSL/1.1.1 zlib/1.2.11 libidn2/2.0.4 libpsl/0.19.1 (+libidn2/2.0.4) nghttp2/1.30.0 librtmp/2.3
Platform: Linux 4.15.0-62-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.22
    Boost: 1.65.1
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.58.0
    Compiler: GCC 7.4.0 with C++ ABI 1011

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Nick Østergaard (nickoe)]

I know this is a bit on the edge, but I will target 5.1.5 for now to have it re-reviewed soon.

[Fabien Corona (drinausaur)]

The problem is that the color of LAYER_VIAS_HOLES in high contrast mode depends on other layers.

Patch proposal:
-Added rule for vias in the color selector, that checks if the via does not belong to any layer registered in m_activeLayers that is visible, then apply a dark color.

Note: When toggling the visibility property of a layer a via is on, the via color does not change if that layer is the selected one. I need to select the layer name to refresh it. I don't know if this should be considered as a related bug, or a different one. See video

[Fabien Corona (drinausaur)]

Alternative patch that also affects the outer circle of vias.
Microvias were always darkened.
Parts of buried/blind vias were always darkened.
Through via were bright, even if the current layer is set as "non-visible".
It slightly extends beyond the scope of this bug, but I think this is related.

[Seth Hillbrand (sethh)]

Committed with minor formatting mods.

Thanks Fabien!

[KiCad Janitor (kicad-janitor)]

Fixed in revision 04edc6ceffdc3deca6e1c9ed420842b48027ac8c
https://git.launchpad.net/kicad/patch/?id=04edc6ceffdc3deca6e1c9ed420842b48027ac8c