Footprint editor cause crash when remove pin

[Abel11]

When try to delete one of holes around pin hole from "AK300-2HC" footprint in attached library (created with Kicad 5.0 or earlier) program get crash. No matter if i open existing project with this library added as global or create new project allways attempt to remove any hole cause crash.

Windows crash report:
Podpis problemu:
  Nazwa zdarzenia problemu: APPCRASH
  Nazwa aplikacji: kicad.exe
  Wersja aplikacji: 0.0.0.0
  Sygnatura czasowa aplikacji: 00000000
  Nazwa modułu z błędem: _pcbnew.kiface
  Wersja modułu z błędem: 0.0.0.0
  Sygnatura czasowa modułu z błędem: 00000000
  Kod wyjątku: c0000005
  Przesunięcie wyjątku: 00000000009c4229
  Wersja systemu operacyjnego: 6.1.7601.2.1.0.256.48
  Identyfikator ustawień regionalnych: 1045
  Dodatkowe informacje 1: 23b3
  Dodatkowe informacje 2: 23b3537fc51970f1db1ccc34d55c889f
  Dodatkowe informacje 3: e9c7
  Dodatkowe informacje 4: e9c7762962809e04fb4dabd1faf128c1

KiCAD informations:
Application: KiCad
Version: (5.1.4)-1, release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.1 OpenSSL/1.1.1 (WinSSL) zlib/1.2.11 brotli/1.0.6 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) nghttp2/1.34.0
Platform: Windows 7 (build 7601, Service Pack 1), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.68.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.1
    Compiler: GCC 8.2.0 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Seth Hillbrand (sethh)]

I can see this on Mac as well

Application: Pcbnew
Version: (5.1.4-0-10_14), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.54.0 LibreSSL/2.6.4 zlib/1.2.11 nghttp2/1.24.1
Platform: Mac OS X (Darwin 18.2.0 x86_64), 64 bit, Little endian, wxMac
Build Info:
    wxWidgets: 3.0.4 (wchar_t,STL containers,compatible with 2.8)
    Boost: 1.69.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.54.0
    Compiler: Clang 9.0.0 with C++ ABI 1002

Build settings:
    USE_WX_GRAPHICS_CONTEXT=ON
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Process: kicad [5105]
Path: /private/var/folders/*/kicad.app/Contents/MacOS/kicad
Identifier: org.kicad-pcb.kicad
Version: 5.1.4 (???)
Code Type: X86-64 (Native)
Parent Process: ??? [1]
Responsible: kicad [5105]
User ID: 501

Date/Time: 2019-08-28 06:21:41.720 -0700
OS Version: Mac OS X 10.14.3 (18D42)
Report Version: 12
Anonymous UUID: C083AEEE-2E06-47E7-F44A-A7C580754DDB

Sleep/Wake UUID: AFC97414-958F-4851-A96E-9A0B8C406A5F

Time Awake Since Boot: 2500000 seconds
Time Since Wake: 39000 seconds

System Integrity Protection: enabled

Notes: Translocated Process

Crashed Thread: 13

Exception Type: EXC_BAD_ACCESS (SIGSEGV)
Exception Codes: KERN_INVALID_ADDRESS at 0x00000000000001d0
Exception Note: EXC_CORPSE_NOTIFY

Termination Signal: Segmentation fault: 11
Termination Reason: Namespace SIGNAL, Code 0xb
Terminating Process: exc handler [5105]

VM Regions Near 0x1d0:
-->
    __TEXT 0000000101788000-0000000101893000 [ 1068K] r-x/rwx SM=COW /var/folders/*/kicad.app/Contents/MacOS/kicad

Thread 0:: Dispatch queue: com.apple.main-thread
0 com.apple.AppKit 0x00007fff496a00df -[NSWindow(NSEventRouting) _handleMouseDownEvent:isDelayedEvent:] + 5400
1 com.apple.AppKit 0x00007fff495d4223 -[NSWindow(NSEventRouting) _reallySendEvent:isDelayedEvent:] + 2319
2 com.apple.AppKit 0x00007fff495d36c9 -[NSWindow(NSEventRouting) sendEvent:] + 481
3 libwx_osx_cocoau-3.0.0.4.0.dylib 0x0000000101b32fcb -[wxNSWindow sendEvent:] + 123
4 com.apple.AppKit 0x00007fff49470954 -[NSApplication(NSEvent) sendEvent:] + 336
5 libwx_osx_cocoau-3.0.0.4.0.dylib 0x0000000101a5ec42 -[wxNSApplication sendEvent:] + 98
6 com.apple.AppKit 0x00007fff4945e19d -[NSApplication run] + 755
7 libwx_osx_cocoau-3.0.0.4.0.dylib 0x0000000101b2864e wxGUIEventLoop::OSXDoRun() + 174
8 libwx_osx_cocoau-3.0.0.4.0.dylib 0x0000000101a23161 wxCFEventLoop::DoRun() + 49
9 libwx_osx_cocoau-3.0.0.4.0.dylib 0x0000000101970bc2 wxEventLoopBase::Run() + 162
10 libwx_osx_cocoau-3.0.0.4.0.dylib 0x000000010193f4b3 wxAppConsoleBase::MainLoop() + 99
11 libwx_osx_cocoau-3.0.0.4.0.dylib 0x0000000101ac195a wxApp::OnRun() + 2...

[Ian McInerney (imcinerney)]

@Seth, the footprint is locked, so this seems to be just another case of https://bugs.launchpad.net/kicad/+bug/1839534. I just tested on the head of 5.1 and master and it doesn't crash but instead just gives the tooltip saying you are trying to delete a locked item.