Custom pad arc primitive start and center exchanged in dialog

Bug #1842199 reported by Rene Poeschl
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
KiCad
Fix Released
Medium
Jeff Young

Bug Description

The custom shape primitive dialog shows the center as start point. The file format calls these start and end (but start is the center strangely. Might be something for v6 to fix as the file format is not really readable this way.)

My kicad version:
Application: ModEdit
Version: 5.1.4-1.fc30, release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.65.3 OpenSSL/1.1.1c-fips zlib/1.2.11 brotli/1.0.7 libidn2/2.2.0 libpsl/0.20.2 (+libidn2/2.0.5) libssh/0.9.0/openssl/zlib nghttp2/1.39.2
Platform: Linux 5.2.9-200.fc30.x86_64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.24
    Boost: 1.69.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.65.3
    Compiler: GCC 9.1.1 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Tags: pcbnew
Revision history for this message
Rene Poeschl (poeschlr) wrote :
description: updated
tags: added: pcbnew
Revision history for this message
Michael Kavanagh (michaelkavanagh) wrote :

@Rene, are you just requesting that the dialog "Start point" and "Centre" labels are swapped?

Revision history for this message
Rene Poeschl (poeschlr) wrote :

For v5 yes. The fact that the center is named start in the file format might be something to fix long term. (As it is kind of confusing right now)

Revision history for this message
Novak Tamas (novak-7) wrote :

I think only the textlabels on the UI are exchanged. Top s huold be "Center" and 2nd line "Starting point".

Changed in kicad:
importance: Undecided → Medium
milestone: none → 6.0.0-rc1
status: New → Triaged
Revision history for this message
Rene Poeschl (poeschlr) wrote :

Why set the milestone to v6 for a gui bug?

Revision history for this message
Michael Kavanagh (michaelkavanagh) wrote :

I took a look at the code and I don't believe its as simple as just exchanging the labels. If the dev who picks it up decides it can be cherrypicked to 5.1, they can change the milestone.

Revision history for this message
Jeff Young (jeyjey) wrote :

It can't be cherry-picked (too many other changes in the Pad Properties dialog), but it's probably bad enough to warrant a separate fix in 5.1.x.

Changed in kicad:
assignee: nobody → Jeff Young (jeyjey)
status: Triaged → In Progress
Revision history for this message
KiCad Janitor (kicad-janitor) wrote :

Fixed in revision f1790c24e5032e1e92fe7f02447c2edb22608308
https://git.launchpad.net/kicad/patch/?id=f1790c24e5032e1e92fe7f02447c2edb22608308

Changed in kicad:
status: In Progress → Fix Committed
Jeff Young (jeyjey)
Changed in kicad:
milestone: 6.0.0-rc1 → 5.1.5
status: Fix Committed → In Progress
Jeff Young (jeyjey)
Changed in kicad:
status: In Progress → Fix Committed
Revision history for this message
Tim N. Tashpulatov (tim-tashpulatov) wrote :

Also X and Y appear swapped in Primitives list.

On attached screenshot, Arc starts at Y axis (Y=0).

Application: ModEdit
Version: (5.1.4)-1, release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.1 OpenSSL/1.1.1 (WinSSL) zlib/1.2.11 brotli/1.0.6 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) nghttp2/1.34.0
Platform: Windows 7 (build 7601, Service Pack 1), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.68.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.1
    Compiler: GCC 8.2.0 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Changed in kicad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.